Skip to content

ci(workflow): Update runner images#3357

Merged
szokeasaurusrex merged 1 commit into
masterfrom
szokeasaurusrex/fix-ci
Jul 6, 2026
Merged

ci(workflow): Update runner images#3357
szokeasaurusrex merged 1 commit into
masterfrom
szokeasaurusrex/fix-ci

Conversation

@szokeasaurusrex

Copy link
Copy Markdown
Member

Bump pinned GitHub-hosted runner labels to the newest GA images from actions/runner-images.

This updates Windows jobs to windows-2025 and macOS jobs to macos-26 while keeping Ubuntu on 24.04, which is still the newest GA Ubuntu label.

Ref #3356

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/fix-ci branch 2 times, most recently from 1b096d1 to e85c426 Compare July 6, 2026 09:49
Bump pinned GitHub-hosted runner labels to the newest GA images from actions/runner-images.

Use the x86_64 Homebrew command under Rosetta to fetch the Tahoe OpenSSL bottle for the macOS 26 jobs.

Ref #3356
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/fix-ci branch from e85c426 to 9114bc6 Compare July 6, 2026 11:04
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review July 6, 2026 14:40
@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner July 6, 2026 14:40
@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) July 6, 2026 14:40

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9114bc6. Configure here.

if: matrix.arch == 'x86_64' && steps.cache-openssl-x86.outputs.cache-hit != 'true'
run: |
brew fetch --bottle-tag=sonoma openssl@3
arch -x86_64 brew fetch --bottle-tag=tahoe openssl@3

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale OpenSSL cache after tag

Medium Severity

The x86_64 OpenSSL download now uses arch -x86_64 and --bottle-tag=tahoe, but the actions/cache key is still openssl-x86_64-${{ runner.os }}-${{ steps.cache-date.outputs.month }}. A cache hit skips the new fetch and restores libraries from the old sonoma/native brew path, which can be the wrong architecture or macOS bottle for macos-26 cross-compiles.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 9114bc6. Configure here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no cache hit on this PR, so I don't think this is relevant

@szokeasaurusrex szokeasaurusrex merged commit 14ba8c3 into master Jul 6, 2026
31 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/fix-ci branch July 6, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants