Skip to content

perf: Avoid boxing in doubleToBigDecimal timestamp serialization #5551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
runningcode merged 2 commits into from
Jun 17, 2026
Merged

perf: Avoid boxing in doubleToBigDecimal timestamp serialization #5551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4583ac
perf: Avoid boxing in doubleToBigDecimal timestamp serialization
runningcode Jun 16, 2026
0f82222
changelog
runningcode Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

### Improvements

- Reduce boxing to improve performance ([#5523](https://github.com/getsentry/sentry-java/pull/5523), [#5527](https://github.com/getsentry/sentry-java/pull/5527))
- Reduce boxing to improve performance ([#5523](https://github.com/getsentry/sentry-java/pull/5523), [#5527](https://github.com/getsentry/sentry-java/pull/5527), [#5551](https://github.com/getsentry/sentry-java/pull/5551))

### Dependencies

Expand Down
2 changes: 1 addition & 1 deletion sentry/api/sentry.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ public final class io/sentry/DataCategory : java/lang/Enum {
public final class io/sentry/DateUtils {
public static fun dateToNanos (Ljava/util/Date;)J
public static fun dateToSeconds (Ljava/util/Date;)D
public static fun doubleToBigDecimal (Ljava/lang/Double;)Ljava/math/BigDecimal;
public static fun doubleToBigDecimal (D)Ljava/math/BigDecimal;
public static fun getCurrentDateTime ()Ljava/util/Date;
public static fun getDateTime (J)Ljava/util/Date;
public static fun getDateTime (Ljava/lang/String;)Ljava/util/Date;
Expand Down
2 changes: 1 addition & 1 deletion sentry/src/main/java/io/sentry/DateUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ public static long secondsToNanos(final @NotNull long seconds) {
return seconds * (1000L * 1000L * 1000L);
}

public static @NotNull BigDecimal doubleToBigDecimal(final @NotNull Double value) {
public static @NotNull BigDecimal doubleToBigDecimal(final double value) {
return BigDecimal.valueOf(value).setScale(6, RoundingMode.DOWN);
}
}
8 changes: 2 additions & 6 deletions sentry/src/main/java/io/sentry/ProfileChunk.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package io.sentry;

import static io.sentry.DateUtils.doubleToBigDecimal;

import io.sentry.profilemeasurements.ProfileMeasurement;
import io.sentry.protocol.DebugMeta;
import io.sentry.protocol.SdkVersion;
Expand All @@ -8,8 +10,6 @@
import io.sentry.vendor.gson.stream.JsonToken;
import java.io.File;
import java.io.IOException;
import java.math.BigDecimal;
import java.math.RoundingMode;
import java.util.HashMap;
import java.util.Map;
import java.util.Objects;
Expand Down Expand Up @@ -264,10 +264,6 @@ public void serialize(final @NotNull ObjectWriter writer, final @NotNull ILogger
writer.endObject();
}

private @NotNull BigDecimal doubleToBigDecimal(final @NotNull Double value) {
return BigDecimal.valueOf(value).setScale(6, RoundingMode.DOWN);
}

@Nullable
@Override
public Map<String, Object> getUnknown() {
Expand Down
8 changes: 2 additions & 6 deletions sentry/src/main/java/io/sentry/profilemeasurements/ProfileMeasurementValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package io.sentry.profilemeasurements;

import static io.sentry.DateUtils.doubleToBigDecimal;

import io.sentry.DateUtils;
import io.sentry.ILogger;
import io.sentry.JsonDeserializer;
Expand All @@ -10,8 +12,6 @@
import io.sentry.util.Objects;
import io.sentry.vendor.gson.stream.JsonToken;
import java.io.IOException;
import java.math.BigDecimal;
import java.math.RoundingMode;
import java.util.Date;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
Expand Down Expand Up @@ -92,10 +92,6 @@ public void serialize(final @NotNull ObjectWriter writer, final @NotNull ILogger
writer.endObject();
}

private @NotNull BigDecimal doubleToBigDecimal(final @NotNull Double value) {
return BigDecimal.valueOf(value).setScale(6, RoundingMode.DOWN);
}

@Nullable
@Override
public Map<String, Object> getUnknown() {
Expand Down
8 changes: 2 additions & 6 deletions sentry/src/main/java/io/sentry/protocol/SentrySpan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package io.sentry.protocol;

import static io.sentry.DateUtils.doubleToBigDecimal;

import io.sentry.DateUtils;
import io.sentry.ILogger;
import io.sentry.JsonDeserializer;
Expand All @@ -16,8 +18,6 @@
import io.sentry.util.Objects;
import io.sentry.vendor.gson.stream.JsonToken;
import java.io.IOException;
import java.math.BigDecimal;
import java.math.RoundingMode;
import java.util.Date;
import java.util.HashMap;
import java.util.Map;
Expand Down Expand Up @@ -230,10 +230,6 @@ public void serialize(final @NotNull ObjectWriter writer, final @NotNull ILogger
writer.endObject();
}

private @NotNull BigDecimal doubleToBigDecimal(final @NotNull Double value) {
return BigDecimal.valueOf(value).setScale(6, RoundingMode.DOWN);
}

@Nullable
@Override
public Map<String, Object> getUnknown() {
Expand Down
8 changes: 2 additions & 6 deletions sentry/src/main/java/io/sentry/protocol/profiling/SentrySample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package io.sentry.protocol.profiling;

import static io.sentry.DateUtils.doubleToBigDecimal;

import io.sentry.ILogger;
import io.sentry.JsonDeserializer;
import io.sentry.JsonSerializable;
Expand All @@ -8,8 +10,6 @@
import io.sentry.ObjectWriter;
import io.sentry.vendor.gson.stream.JsonToken;
import java.io.IOException;
import java.math.BigDecimal;
import java.math.RoundingMode;
import java.util.HashMap;
import java.util.Map;
import org.jetbrains.annotations.ApiStatus;
Expand Down Expand Up @@ -78,10 +78,6 @@ public void serialize(@NotNull ObjectWriter writer, @NotNull ILogger logger) thr
writer.endObject();
}

private @NotNull BigDecimal doubleToBigDecimal(final @NotNull Double value) {
return BigDecimal.valueOf(value).setScale(6, RoundingMode.DOWN);
}

@Nullable
@Override
public Map<String, Object> getUnknown() {
Expand Down
Loading