Skip to content

fix(mac): handle RunInstances scale errors#5183

Merged
edersonbrilhante merged 1 commit into
mainfrom
fix/handle-runinstances-scale-errors
Jun 19, 2026
Merged

fix(mac): handle RunInstances scale errors#5183
edersonbrilhante merged 1 commit into
mainfrom
fix/handle-runinstances-scale-errors

Conversation

@edersonbrilhante

@edersonbrilhante edersonbrilhante commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Description

Adds scale-error handling for the dedicated-host RunInstances path.

RunInstances does not return fleet-style Errors, so the catch block now checks the thrown AWS SDK error name against configured scaleErrors and throws ScaleError to trigger retry behavior. The successful response path is split into processRunInstanceResult to validate returned instance IDs.

Test Plan

  • Tested in my AWS environment with a dedicated-host scale-up where no compatible host capacity was available.
  • Confirmed RunInstances failed with InsufficientHostCapacity, the error was matched through error.name, and ScaleError was thrown so the request is retried.

Related Issues

N/A

@edersonbrilhante edersonbrilhante requested a review from a team as a code owner June 19, 2026 18:47
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@edersonbrilhante edersonbrilhante merged commit 7d8c576 into main Jun 19, 2026
10 checks passed
@edersonbrilhante edersonbrilhante deleted the fix/handle-runinstances-scale-errors branch June 19, 2026 21:57
Brend-Smits pushed a commit that referenced this pull request Jun 24, 2026
🤖 I have created a release *beep* *boop*
---


##
[7.8.0](v7.7.1...v7.8.0)
(2026-06-24)


### Features

* **runners:** add volume_initialization_rate to block_device_mappings
([#5165](#5165))
([449df46](449df46)),
closes
[#5163](#5163)
* support dynamic EC2 placement and block device overrides
([#5178](#5178))
([58fd1c2](58fd1c2))
* **webhook:** enforce per-runner dynamic labels policy in dispatcher
([#5172](#5172))
([d624d96](d624d96))


### Bug Fixes

* **ci:** restore persist-credentials for gh-pages deploy
([#5162](#5162))
([9955d73](9955d73))
* **codeowners:** require admin review for nested .github paths
([#5164](#5164))
([83ea30c](83ea30c))
* **mac:** handle RunInstances scale errors
([#5183](#5183))
([7d8c576](7d8c576))
* **scale-up:** prevent runnerLabels accumulation across dynamic label
groups
([#5176](#5176))
([246949e](246949e)),
closes
[#5175](#5175)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants