Surface eval outcomes in experiments analyze and align experiment workflows/docs with eval-backed metrics - #48741
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
experiments analyze and align experiment workflows/docs with eval-backed metrics
|
@copilot resolve the merge conflicts on this branch. |
There was a problem hiding this comment.
Pull request overview
Adds eval outcome visibility to experiment analysis and aligns workflow guidance with eval-backed metrics.
Changes:
- Loads and summarizes durable eval results in CLI analysis.
- Adds tests and documentation for eval-backed metrics.
- Adds eval definitions and regenerates associated workflows.
Show a summary per file
| File | Description |
|---|---|
pkg/cli/experiments_command.go |
Loads and summarizes eval results. |
pkg/cli/experiments_command_test.go |
Tests eval summarization. |
pkg/cli/experiments_analyze_statistics.go |
Exposes eval outcomes in analysis. |
pkg/cli/experiments_analyze_statistics_test.go |
Tests analysis wiring. |
docs/src/content/docs/experimental/experiments.md |
Documents eval outcome display. |
.github/aw/experiments.md |
Updates experiment guidance. |
.github/workflows/typist.md |
Adds an experiment eval. |
.github/workflows/test-quality-sentinel.md |
Adds an experiment eval. |
.github/workflows/smoke-temporary-id.md |
Adds an experiment eval. |
.github/workflows/smoke-temporary-id.lock.yml |
Compiles eval jobs and persistence. |
.github/workflows/smoke-project.md |
Adds an experiment eval. |
.github/workflows/smoke-project.lock.yml |
Compiles eval jobs and persistence. |
.github/workflows/smoke-gemini.md |
Adds an experiment eval. |
.github/workflows/smoke-gemini.lock.yml |
Compiles eval jobs and persistence. |
.github/workflows/smoke-copilot-sub-agents.md |
Adds an experiment eval. |
.github/workflows/smoke-copilot-sub-agents.lock.yml |
Compiles eval jobs and persistence. |
.github/workflows/smoke-copilot-aoai-entra.md |
Adds experiment evals. |
.github/workflows/smoke-copilot-aoai-apikey.md |
Adds experiment evals. |
.github/workflows/smoke-antigravity.md |
Adds an experiment eval. |
.github/workflows/smoke-antigravity.lock.yml |
Compiles eval jobs and persistence. |
.github/workflows/gpclean.md |
Adds an experiment eval. |
.github/workflows/gpclean.lock.yml |
Compiles eval jobs and persistence. |
.github/workflows/deep-report.md |
Adds an experiment eval. |
.github/workflows/dataflow-pr-discussion-dataset.md |
Adds an experiment eval. |
.github/workflows/dataflow-pr-discussion-dataset.lock.yml |
Compiles eval jobs and persistence. |
.github/workflows/daily-agentrx-trace-optimizer.md |
Adds an experiment eval. |
.github/workflows/daily-agentrx-trace-optimizer.lock.yml |
Compiles eval jobs and persistence. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
pkg/cli/experiments_command.go:345
- The remote path also fetches only the current
evals.jsonlsnapshot. Since the durable-state job replaces that file each run, remote analysis reports only the latest run rather than cumulative outcomes. Load and summarize the branch's historical file versions, or change persistence to append/deduplicate records before committing.
- Files reviewed: 32/32 changed files
- Comments generated: 14
- Review effort level: Medium
| } | ||
| ref = branchName | ||
| } | ||
| cmd := exec.Command("git", "show", ref+":"+constants.EvalsResultFilename) |
| - id: tone_style_goal_met | ||
| question: Does the agent output show that the objective for experiment tone_style was successfully completed? |
| - id: model_size_goal_met | ||
| question: Does the agent output show that the objective for experiment model_size was successfully completed? |
| - id: sub_agent_strategy_goal_met | ||
| question: Does the agent output show that the objective for experiment sub_agent_strategy was successfully completed? |
| - id: prompt_style_test_goal_met | ||
| question: Does the agent output show that the objective for experiment prompt_style_test was successfully completed? |
| - id: sub_agent_strategy_goal_met | ||
| question: Does the agent output show that the objective for experiment sub_agent_strategy was successfully completed? |
| - id: tool_verbosity_goal_met | ||
| question: Does the agent output show that the objective for experiment tool_verbosity was successfully completed? |
| - id: output_format_goal_met | ||
| question: Does the agent output show that the objective for experiment output_format was successfully completed? |
| - id: caveman_mode_goal_met | ||
| question: Does the agent output show that the objective for experiment caveman_mode was successfully completed? |
| - id: sub_agent_strategy_goal_met | ||
| question: Does the agent output show that the objective for experiment sub_agent_strategy was successfully completed? |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
@copilot merge main and recompile |
|
Great work on adding eval-result visibility to experiment analysis! 🎯 This feature enhances the The implementation is solid:
This PR looks ready for review and merge. The feature is well-scoped, thoroughly tested, and the large diff is primarily generated workflow artifacts, not custom logic. Ship it! 🚀 Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "patchdiff.githubusercontent.com"See Network Configuration for more information.
|
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot run pr-finisher skill |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🎉 This pull request is included in a new release. Release: |
gh aw experiments analyzealready resolved eval-backed metric references (eval:<id>/evals.<id>) to question text, but it did not show observed eval outcomes for those metrics. This PR adds eval-result visibility to analysis output and aligns experiment guidance/workflows so experiment metrics can be evaluated consistently.CLI analysis: eval-backed metric outcomes
metric_eval_resultsfor eval-referenced metrics.evals.jsonlfrom durable eval branches (local/remote) by eval ID.Analysis pipeline wiring
computeExperimentAnalyses/computeExperimentAnalysis.Workflow coverage updates
evals:sections to experiment workflows that hadexperiments:but no eval definitions..lock.ymlfiles to keep compiled workflows in sync.Guidance/docs updates
experiments analyzesurfaces resolved eval question + observed eval outcomes.