Skip to content

Loosen actor type on PopupMenuSection#142

Open
AmionSky wants to merge 1 commit into
gjsify:mainfrom
AmionSky:popup
Open

Loosen actor type on PopupMenuSection#142
AmionSky wants to merge 1 commit into
gjsify:mainfrom
AmionSky:popup

Conversation

@AmionSky

Copy link
Copy Markdown
Contributor

PopupMenuSection does set actor to a St.BoxLayout in its constuctor, it does not use it (nor any other code assumes it as a St.BoxLayout), but if I want to modify it in a subclass, it is now limited to subclass of St.BoxLayout instead of Clutter.Actor (which is from the parent class).

I would like to loosen this requirement. Especially since the only thing it does is

this.actor = this.box;

and the St.BoxLayout is still accessible via this.box property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant