fix: skip code regex without delimiters#6012
Conversation
|
I have completed a thorough, read-only analysis of Pull Request #6012 and its linked issue #5992. I have created a premium, structured analysis report artifact: Summary of Analysis & Recommendations
Final Recommendation: Approve (No changes or nits required) 🌟The PR is exceptionally localized, highly elegant, structurally safe, and fixes a severe reliability issue. Please take a look at the full report here and let me know if you would like me to assist with taking over, merging, or further actions on this PR! |
|
Pushed This addresses the mypy-diff failure by returning Validation:
|
|
Hi @he-yufeng , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
|
Hi @GWeale , can you please review this. |
34b1582 to
5a71e46
Compare
5a71e46 to
4e8602f
Compare
|
Rebased this on current
All passed locally. |
Summary
Fixes #5992
To verify
$env:PYTHONPATH='src'; python -m pytest tests\unittests\flows\llm_flows\test_code_execution.py -q$env:PYTHONPATH='src'; python -m ruff check src\google\adk\code_executors\code_execution_utils.py tests\unittests\flows\llm_flows\test_code_execution.pypython -m py_compile src\google\adk\code_executors\code_execution_utils.py tests\unittests\flows\llm_flows\test_code_execution.pygit diff --check