Use cancel-in-progress instead of styfle/cancel-workflow-action.#2085
Open
copybara-service[bot] wants to merge 1 commit into
Open
Use cancel-in-progress instead of styfle/cancel-workflow-action.#2085copybara-service[bot] wants to merge 1 commit into
cancel-in-progress instead of styfle/cancel-workflow-action.#2085copybara-service[bot] wants to merge 1 commit into
Conversation
Advantages: - We don't need to grant write permissions to a third-party action (or even use it at all). - Not that I have any reason to think it's likely to be a problem, but strange things happen sometimes. - One less action means one less thing for us to merge Dependabot updates for. - The new approach can easily allow CI for merged trunk commits to continue even after other trunk commits are merged, while still stopping PR CI when new changes are pushed. - This is especially nice because cancellations (at least those from `styfle/cancel-workflow-action`, maybe in general) show up as _failures_. It's nice to be able to pick out _real_ failures (e.g., those fixed by cl/925609698 and cl/943404496) without sorting through cancellations. - All else being equal, it's nice to have smaller, simpler configuration. Assuming that this approach holds up, I'll replicate it to our other projects. RELNOTES=n/a PiperOrigin-RevId: 943469061
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
cancel-in-progressinstead ofstyfle/cancel-workflow-action.Advantages:
styfle/cancel-workflow-action, maybe in general) show up as failures. It's nice to be able to pick out real failures (e.g., those fixed by cl/925609698 and cl/943404496) without sorting through cancellations.Assuming that this approach holds up, I'll replicate it to our other projects.
RELNOTES=n/a