refactor!: Rename PullRequestReviewDismissalRequest to PullRequestDismissReviewRequest, add PullRequestSubmitReviewRequest, and pass review request bodies by value

.golangci.yml

@@ -243,7 +243,6 @@ linters:
             - PublishCodespaceOptions
             - PullRequestBranchUpdateOptions
             - PullRequestComment
-            - PullRequestReviewDismissalRequest
             - PullRequestReviewRequest
             - PullRequestReviewsEnforcementUpdate
             - Repository

github/pulls_reviews.go

@@ -93,15 +93,22 @@ func (r *PullRequestReviewRequest) isComfortFadePreview() (bool, error) {
 	return false, nil
 }
 
-// PullRequestReviewDismissalRequest represents a request to dismiss a review.
-type PullRequestReviewDismissalRequest struct {
-	Message *string `json:"message,omitempty"`
+// PullRequestDismissReviewRequest represents a request to dismiss a review.
+type PullRequestDismissReviewRequest struct {
+	Message string  `json:"message"`
+	Event   *string `json:"event,omitempty"`
 }
 
-func (r PullRequestReviewDismissalRequest) String() string {
+func (r PullRequestDismissReviewRequest) String() string {
 	return Stringify(r)
 }
 
+// PullRequestSubmitReviewRequest represents a request to submit a review.
+type PullRequestSubmitReviewRequest struct {
+	Body  *string `json:"body,omitempty"`
+	Event string  `json:"event"`
+}
+
 // ListReviews lists all reviews on the specified pull request.
 //
 // GitHub API docs: https://docs.github.com/rest/pulls/reviews?apiVersion=2022-11-28#list-reviews-for-a-pull-request
@@ -293,7 +300,7 @@ func (s *PullRequestsService) UpdateReview(ctx context.Context, owner, repo stri
 // GitHub API docs: https://docs.github.com/rest/pulls/reviews?apiVersion=2022-11-28#submit-a-review-for-a-pull-request
 //
 //meta:operation POST /repos/{owner}/{repo}/pulls/{pull_number}/reviews/{review_id}/events
-func (s *PullRequestsService) SubmitReview(ctx context.Context, owner, repo string, number int, reviewID int64, body *PullRequestReviewRequest) (*PullRequestReview, *Response, error) {
+func (s *PullRequestsService) SubmitReview(ctx context.Context, owner, repo string, number int, reviewID int64, body PullRequestSubmitReviewRequest) (*PullRequestReview, *Response, error) {
 	u := fmt.Sprintf("repos/%v/%v/pulls/%v/reviews/%v/events", owner, repo, number, reviewID)
 
 	req, err := s.client.NewRequest(ctx, "POST", u, body)
@@ -315,7 +322,7 @@ func (s *PullRequestsService) SubmitReview(ctx context.Context, owner, repo stri
 // GitHub API docs: https://docs.github.com/rest/pulls/reviews?apiVersion=2022-11-28#dismiss-a-review-for-a-pull-request
 //
 //meta:operation PUT /repos/{owner}/{repo}/pulls/{pull_number}/reviews/{review_id}/dismissals
-func (s *PullRequestsService) DismissReview(ctx context.Context, owner, repo string, number int, reviewID int64, body *PullRequestReviewDismissalRequest) (*PullRequestReview, *Response, error) {
+func (s *PullRequestsService) DismissReview(ctx context.Context, owner, repo string, number int, reviewID int64, body PullRequestDismissReviewRequest) (*PullRequestReview, *Response, error) {
 	u := fmt.Sprintf("repos/%v/%v/pulls/%v/reviews/%v/dismissals", owner, repo, number, reviewID)
 
 	req, err := s.client.NewRequest(ctx, "PUT", u, body)

github/pulls_reviews_test.go

@@ -512,9 +512,9 @@ func TestPullRequestsService_SubmitReview(t *testing.T) {
 	t.Parallel()
 	client, mux, _ := setup(t)
 
-	input := &PullRequestReviewRequest{
+	input := PullRequestSubmitReviewRequest{
 		Body:  Ptr("b"),
-		Event: Ptr("APPROVE"),
+		Event: "APPROVE",
 	}
 
 	mux.HandleFunc("/repos/o/r/pulls/1/reviews/1/events", func(w http.ResponseWriter, r *http.Request) {
@@ -554,15 +554,15 @@ func TestPullRequestsService_SubmitReview_invalidOwner(t *testing.T) {
 	client, _, _ := setup(t)
 
 	ctx := t.Context()
-	_, _, err := client.PullRequests.SubmitReview(ctx, "%", "r", 1, 1, &PullRequestReviewRequest{})
+	_, _, err := client.PullRequests.SubmitReview(ctx, "%", "r", 1, 1, PullRequestSubmitReviewRequest{})
 	testURLParseError(t, err)
 }
 
 func TestPullRequestsService_DismissReview(t *testing.T) {
 	t.Parallel()
 	client, mux, _ := setup(t)
 
-	input := &PullRequestReviewDismissalRequest{Message: Ptr("m")}
+	input := PullRequestDismissReviewRequest{Message: "m", Event: Ptr("DISMISS")}
 
 	mux.HandleFunc("/repos/o/r/pulls/1/reviews/1/dismissals", func(w http.ResponseWriter, r *http.Request) {
 		testMethod(t, r, "PUT")
@@ -601,6 +601,6 @@ func TestPullRequestsService_DismissReview_invalidOwner(t *testing.T) {
 	client, _, _ := setup(t)
 
 	ctx := t.Context()
-	_, _, err := client.PullRequests.DismissReview(ctx, "%", "r", 1, 1, &PullRequestReviewDismissalRequest{})
+	_, _, err := client.PullRequests.DismissReview(ctx, "%", "r", 1, 1, PullRequestDismissReviewRequest{})
 	testURLParseError(t, err)
 }

github/strings_test.go

@@ -202,7 +202,7 @@ func TestString(t *testing.T) {
 		{PullRequestReview{ID: Ptr(int64(1))}, `github.PullRequestReview{ID:1}`},
 		{DraftReviewComment{Position: Ptr(1)}, `github.DraftReviewComment{Position:1}`},
 		{PullRequestReviewRequest{Body: Ptr("r")}, `github.PullRequestReviewRequest{Body:"r"}`},
-		{PullRequestReviewDismissalRequest{Message: Ptr("r")}, `github.PullRequestReviewDismissalRequest{Message:"r"}`},
+		{PullRequestDismissReviewRequest{Message: "r"}, `github.PullRequestDismissReviewRequest{Message:"r"}`},
 		{HeadCommit{SHA: Ptr("s")}, `github.HeadCommit{SHA:"s"}`},
 		{PushEvent{PushID: Ptr(int64(1))}, `github.PushEvent{PushID:1}`},
 		{Reference{Ref: Ptr("r")}, `github.Reference{Ref:"r"}`},