fix(storage): forward predefinedAcl on compose over JSON - #13975
Open
gaul wants to merge 1 commit into
Open
Conversation
Storage.compose accepts BlobTargetOption.predefinedAcl and carries it down as StorageRpc.Option.PREDEFINED_ACL, but HttpStorageRpc.compose forwarded only the generation, metageneration and userProject options. The caller was given no error: objects.compose ran without destinationPredefinedAcl and the composed object kept the ACL it would have had anyway, so an object asked to be public came back private. The two transports disagreed on the same call. UnifiedOpts.PredefinedAcl already implements composeObject as setDestinationPredefinedAcl, so gRPC applied the option while JSON dropped it, and which one a caller got depended on how the client had been built. Objects.Compose has taken destinationPredefinedAcl all along; set it as rewrite already does a few lines below.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the compose method in HttpStorageRpc to set the destination predefined ACL on the compose request using the target options. It also introduces a new test class HttpStorageRpcComposeTest to verify that the predefined ACL option is correctly forwarded when provided and omitted when not. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storage.compose accepts BlobTargetOption.predefinedAcl and carries it down as StorageRpc.Option.PREDEFINED_ACL, but HttpStorageRpc.compose forwarded only the generation, metageneration and userProject options. The caller was given no error: objects.compose ran without destinationPredefinedAcl and the composed object kept the ACL it would have had anyway, so an object asked to be public came back private.
The two transports disagreed on the same call. UnifiedOpts.PredefinedAcl already implements composeObject as setDestinationPredefinedAcl, so gRPC applied the option while JSON dropped it, and which one a caller got depended on how the client had been built.
Objects.Compose has taken destinationPredefinedAcl all along; set it as rewrite already does a few lines below.