chore: Add the PQC conformance tests#9299
Draft
Hectorhammett wants to merge 1 commit into
Draft
Conversation
Hectorhammett
added
the
do not merge
bshaffer
reviewed
Jun 24, 2026
| - name: Install GAPIC Showcase from Branch | ||
| run: | | ||
| curl -L https://github.com/googleapis/gapic-showcase/releases/download/v${GAPIC_SHOWCASE_VERSION}/gapic-showcase-${GAPIC_SHOWCASE_VERSION}-${OS}-${ARCH}.tar.gz | tar -zx | ||
| ./gapic-showcase run & |
Contributor
There was a problem hiding this comment.
You upgraded the showcase version but then removed the lines using it? I assume these will be added back once the feat-pqc-tls branch is merged and tagged?
Collaborator
Author
There was a problem hiding this comment.
I hope so, this is for now as it is what it "works". If it gets merged and tagged, we are updatting this.
Collaborator
Author
There was a problem hiding this comment.
I am a bit confused, we did not removed the lines using it, is under the next step:
Run the GAPIC showcase server
| @@ -0,0 +1,100 @@ | |||
| <?php | |||
| /* | |||
| * Copyright 2021 Google LLC | |||
Contributor
There was a problem hiding this comment.
Suggested change
| * Copyright 2021 Google LLC | |
| * Copyright 2026 Google LLC |
|
|
||
| public function provideTransport(): array | ||
| { | ||
| $pemPath = __DIR__ . '/showcase.pem'; |
Collaborator
Author
There was a problem hiding this comment.
It is autogenerated by the showcase server when started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the PQC conformance tests to GAX.