Skip to content

feat(storage): expose object_metadata on AsyncMultiRangeDownloader #17411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuxin00j wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −0
Open

feat(storage): expose object_metadata on AsyncMultiRangeDownloader #17411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00c2c30
feat(storage): expose object_metadata on AsyncMultiRangeDownloader
yuxin00j Jun 10, 2026
649291f
refactor: use property for object_metadata
yuxin00j Jun 10, 2026
47cf748
test: add assertions for object_metadata property
yuxin00j Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/google-cloud-storage/google/cloud/storage/asyncio/async_multi_range_downloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,3 +577,9 @@ async def close(self):
@property
def is_stream_open(self) -> bool:
return self._is_stream_open

@property
def object_metadata(self) -> Optional[_storage_v2.Object]:
"""The metadata of the object being downloaded."""
stream = getattr(self, "read_obj_str", None)
return stream.object_metadata if stream else None
3 changes: 3 additions & 0 deletions packages/google-cloud-storage/tests/unit/asyncio/test_async_multi_range_downloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ async def _make_mock_mrd(
mock_stream.generation_number = _TEST_GENERATION_NUMBER
mock_stream.persisted_size = _TEST_OBJECT_SIZE
mock_stream.read_handle = _TEST_READ_HANDLE
mock_stream.object_metadata = mock.Mock()

mrd = await AsyncMultiRangeDownloader.create_mrd(
mock_client, bucket_name, object_name, generation, read_handle
Expand Down Expand Up @@ -93,6 +94,7 @@ async def test_create_mrd(self, mock_cls_async_read_object_stream):
assert mrd.read_handle == _TEST_READ_HANDLE
assert mrd.persisted_size == _TEST_OBJECT_SIZE
assert mrd.is_stream_open
assert mrd.object_metadata == mrd.read_obj_str.object_metadata
assert mrd._open_retries == 0

@mock.patch(
Expand Down Expand Up @@ -275,6 +277,7 @@ async def test_close_mrd(self, mock_cls_async_read_object_stream):

# Assert
assert not mrd.is_stream_open
assert mrd.object_metadata is None

@pytest.mark.asyncio
async def test_close_mrd_not_opened_should_throw_error(self):
Expand Down
Loading