Add test to verify all the valid subgroup sizes work for subgroup size attribute#4666
Open
Jiawei-Shao wants to merge 4 commits into
Open
Add test to verify all the valid subgroup sizes work for subgroup size attribute#4666Jiawei-Shao wants to merge 4 commits into
Jiawei-Shao wants to merge 4 commits into
Conversation
…e attribute This patch adds an execution test to verify all the power-of-two values in [SubgroupMinSize, SubgroupMaxSize] can be used as @subgroup_size attribute in a simple compute pipeline.
|
Results for build job (at c729f59): -webgpu:shader,execution,shader_io,compute_builtins:subgroup_size_attribute:* - 6 cases, 6 subcases (~1/case)
+webgpu:shader,execution,shader_io,compute_builtins:subgroup_size_attribute:* - 36 cases, 36 subcases (~1/case)
-TOTAL: 283009 cases, 2325912 subcases
+TOTAL: 283039 cases, 2325942 subcases |
Collaborator
Author
|
@jrprice @kainino0x PTAL, thanks! |
kainino0x
approved these changes
Jun 19, 2026
| new Uint32Array([...iterRange(numInvocations, x => 0)]), | ||
| GPUBufferUsage.STORAGE | GPUBufferUsage.COPY_SRC | GPUBufferUsage.COPY_DST | ||
| ); | ||
| t.trackForCleanup(outputBuffer); |
Collaborator
There was a problem hiding this comment.
existing nit: not needed, makeBufferWithContents does it already.
Collaborator
Author
There was a problem hiding this comment.
Done.
Note that the added test about subgroup_size == 8 will fail on Intel Gen12 GPUs using D3D12 driver.
jrprice
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds an execution test to verify all the power-of-two values in [SubgroupMinSize, SubgroupMaxSize] can be used as @subgroup_size attribute in a simple compute pipeline.
This patch also adds a validation test that a pipeline creation error occurs when the subgroup size is smaller than
SubgroupMinSizeor greater thanSubgroupMaxSize.Issue: #4640
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.