Add team url to FootballTeam#16376
Open
marjisound wants to merge 2 commits into
Open
Conversation
marjisound
force-pushed
the
add-team-url-to-football-team
branch
from
7c82a91 to
12a4665
Compare
github-actions
Bot
removed
the
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adding an optional teamUrl field to FootballTeam and as a result we can now use that url to make the team names clickable on football header.
For the apps deep linking to work, we need to use full path urls so I had to add the baseUrl to the teamUrl.
This PR can ONLY be merged after the frontend PR relevant guardian/frontend#28945
Web
Screen.Recording.2026-07-14.at.12.10.07.mov
iOS
Screen.Recording.2026-07-14.at.15.50.37.mov