chore: convert to ESM - #79
Open
damusix wants to merge 8 commits into
Open
Conversation
Convert package from CommonJS to native ES modules. All tests passing with no memory leaks.
Completes the ESM conversion: lab/code/eslint-plugin swapped for vitest + @hapi/oxc-plugin, conditional exports, Node 22 baseline. Version reset to the published 6.0.3 — the release process owns bumps.
ESM module scope already makes these private; exporting nothing is what keeps them so. media.js's `internals.preferences` becomes `filterPreferences` to avoid shadowing the `preferences` parameter.
hoek 12 is the ESM-only release; matches the pin hapijs/topo#74 and hapijs/boom#309 set. @hapi/boom stays on 10 (still CJS), so hoek 11 remains in the tree transitively.
@hapi/oxc-plugin 1.0.4 peers on oxfmt >=0.61.0, so a fresh install hit ERESOLVE against the pinned oxfmt ^0.57.0. Versions now match the concurrent topo/boom conversions.
Conflicts kept this branch's vitest/oxc toolchain over next's lab devDeps, and its min-node-22 CI target; next's 'next' push trigger was taken.
Matches the convention in the published ESM RCs (topo, boom, teamwork, file): no grouped export clause, no default export.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the package onto the toolchain the recent conversions established:
src/layout, conditional exports, vitest +@hapi/oxc-plugin, Node 22baseline.
@hapi/hoekis pinned to^12.0.0-rc.0to match #74 in topo and #309 inboom.
@hapi/boomstays at^10.0.1until its own conversion lands, sotwo hoek majors coexist in the tree — only hoek's main export is imported,
so no subpath is involved.
API.mdis added tofiles; npm does not ship it automatically.Supersedes #77.