Skip to content

feat: print deprecated Load Balancer Type information - #1461

Merged
jooola merged 5 commits into
mainfrom
load-balancer-type-deprecation
Jul 29, 2026
Merged

feat: print deprecated Load Balancer Type information#1461
jooola merged 5 commits into
mainfrom
load-balancer-type-deprecation

Conversation

@phm07

@phm07 phm07 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

This PR adds warnings for deprecated Load Balancer Types and displays the deprecation info in the list and describe commands.

@phm07 phm07 self-assigned this Jul 24, 2026
@phm07
phm07 requested a review from a team as a code owner July 24, 2026 15:41
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.08%. Comparing base (eb22404) to head (debf9ac).

Files with missing lines Patch % Lines
internal/cmd/loadbalancer/create.go 60.00% 2 Missing and 2 partials ⚠️
internal/cmd/loadbalancertype/list.go 20.00% 3 Missing and 1 partial ⚠️
internal/cmd/loadbalancer/texts.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1461      +/-   ##
==========================================
- Coverage   73.12%   73.08%   -0.05%     
==========================================
  Files         300      301       +1     
  Lines       11081    11097      +16     
==========================================
+ Hits         8103     8110       +7     
- Misses       2084     2090       +6     
- Partials      894      897       +3     
Flag Coverage Δ
e2e 51.45% <50.00%> (-0.06%) ⬇️
unit 67.93% <62.50%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phm07

phm07 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Waiting for next hcloud-go release so that we can use the new deprecationutil

@jooola jooola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The lb type describe command does not print the deprecation info.
  • The lb type list command does not have a "deprecated" column.
  • The old lb type deprecated property is deprecation, the deprecation object must be used instead.

@phm07
phm07 requested a review from jooola July 29, 2026 08:35
@jooola

jooola commented Jul 29, 2026

Copy link
Copy Markdown
Member

Please merge #1459 and rebase this branch on top of it.

@phm07
phm07 force-pushed the load-balancer-type-deprecation branch from f6fb673 to debf9ac Compare July 29, 2026 09:17
@jooola jooola changed the title docs: print deprecated Load Balancer Type information if present feat: print deprecated Load Balancer Type information if present Jul 29, 2026
@jooola jooola changed the title feat: print deprecated Load Balancer Type information if present feat: print deprecated Load Balancer Type information Jul 29, 2026
@jooola
jooola merged commit 22a60bc into main Jul 29, 2026
9 of 10 checks passed
@jooola
jooola deleted the load-balancer-type-deprecation branch July 29, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants