feat(application): ROSS-174: refactored, cleanup the application and docs#63
Merged
Conversation
…ename basePath to path
…ve enabled check to server.ts, remove logs
…ace alignment
- Add required ['openapi'] to docsSchema so empty docs: {} fails validation
- Make description optional in TS interface (matches schema + OpenAPI spec)
- Make version required in both schema and TS (required by OpenAPI spec)
- Lower application.name minLength from 5 to 1
- Lower docs.openapi.info.description minLength from 25 to 1
- Add test coverage for missing version and missing openapi
…ded '/docs' in welcome filter
- Filter swagger routes by checking if URL starts with
config.docs.openapi.path instead of substring includes('/docs')
- Remove the overly broad includes('/static') filter — swagger
static assets are under <swaggerPath>/static/ and are caught
by the path-prefix check
- Only apply filtering when swagger is enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.