chore: fix aioresponses support and update codecoverage gpg#712
Open
karel-rehor wants to merge 3 commits into
Open
chore: fix aioresponses support and update codecoverage gpg#712karel-rehor wants to merge 3 commits into
karel-rehor wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Note that this client library is currently in maintenance mode only, so maintenance time is a factor in implementing these changes. There are no plans to remove support for older python versions, nor to make newer python versions a standard reference point.
aioresponses
The most recent release of the
aioresponseslibrary presents a couple of problems.aiohttp, the absence of which leads to compilation problems, such as mismatched constructor signatures forClientResponse. (aiohttpalso dropped support for python 3.7 and older a few years ago).solution:
codecoverage
Endpoints for gpg data have changed. These have been updated.
Checklist
pytest testscompletes successfully