Deprecate execution_capability and execution_capabilities - #22757
Draft
mianowski wants to merge 5 commits into
Draft
Deprecate execution_capability and execution_capabilities#22757mianowski wants to merge 5 commits into
mianowski wants to merge 5 commits into
Conversation
KornevNikita
left a comment
KornevNikita
left a comment
Contributor
There was a problem hiding this comment.
Preliminary draft review.
| using return_type = bool; | ||
| }; | ||
| struct execution_capabilities | ||
| struct __SYCL2020_DEPRECATED("deprecated in SYCL 2020") execution_capabilities |
Contributor
There was a problem hiding this comment.
Nice catch, I didn't even realize that this is still not deprecated.
| } | ||
| } | ||
|
|
||
| template <> std::string info_to_string(info::execution_capability info) { |
Contributor
There was a problem hiding this comment.
I don't think we should remove code in this test. It's deprecated to encourage users to drop using this, although we're still supporting it.
| /// [::ur_device_exec_capability_flags_t] device kernel execution | ||
| /// capability bit-field | ||
| UR_DEVICE_INFO_EXECUTION_CAPABILITIES = 59, | ||
| /// [::ur_device_exec_capability_flags_t][deprecated-value] device kernel |
Contributor
There was a problem hiding this comment.
I believe changes on the UR level might be excessive. Just drop SYCL support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers #22735