[SYCL] Make enable_profiling and enable_ipc properties match the spec - #22787
Open
againull wants to merge 1 commit into
Open
[SYCL] Make enable_profiling and enable_ipc properties match the spec#22787againull wants to merge 1 commit into
againull wants to merge 1 commit into
Conversation
Convert 'enable_profiling' (from sycl_ext_oneapi_reusable_events) and
'enable_ipc' (from sycl_ext_oneapi_inter_process_communication) from
compile-time flag properties to runtime properties that accept a
'bool enable' argument. This matches what both extension specs
already document and examples in those specs imply that those are
runtime properties. Current implementation is not able to compile
examples provided in the specification.
As a runtime property, the same properties list can express either state:
syclex::make_event(
ctx,
syclex::properties{syclex::enable_profiling{some_runtime_bool},
syclex::enable_ipc{another_runtime_bool}});
And allows to avoid this kind of branching:
if (enable_profiling) {
return syclex::make_event(context, syclex::enable_profiling);
} else if (enable_ipc) {
return syclex::make_event(context, syclex::enable_ipc);
} else
return syclex::make_event(context);
}
Assisted-By: Claude
gmlueck
approved these changes
Jul 28, 2026
gmlueck
left a comment
gmlueck
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Spec change is good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert
enable_profiling(fromsycl_ext_oneapi_reusable_event) andenable_ipc(fromsycl_ext_oneapi_inter_process_communication) from compile-time flag properties to runtime properties that accept abool enableargument. This matches what both extension specs already document and examples in those specs imply that those are runtime properties. Current implementation is not able to compile examples provided in the specification.As a runtime property, the same properties list can express either state:
And allows to avoid this kind of branching:
Assisted-By: Claude