Operator API | Change No Show Blocks to Service Violation Blocks#745
Open
anm-ioki wants to merge 3 commits into
Open
Operator API | Change No Show Blocks to Service Violation Blocks#745anm-ioki wants to merge 3 commits into
anm-ioki wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Operator API client to use the new service violation block endpoints and models in place of the former no show block ones, aligning the gem’s Operator API surface with the backend API rename.
Changes:
- Renames the Operator model from
NoShowBlocktoServiceViolationBlock. - Updates Operator API endpoint definitions to use
service_violation_block(s)paths and method names (includingacknowledge). - Updates Operator API specs to assert the new URLs and returned model class.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/ioki/operator_api_spec.rb | Updates request URL and return-type expectations for the renamed service violation block endpoints. |
| lib/ioki/model/operator/service_violation_block.rb | Renames the Operator model class to ServiceViolationBlock. |
| lib/ioki/apis/operator_api.rb | Replaces no-show-block endpoint wiring with service-violation-block endpoints and model bindings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Operator API now has new endpoints for service violation blocks to replace the existing no show blocks. These changes use the new endpoints and rename the models accordingly.