Skip to content

Fix exception caused when marshalling models#746

Merged
phylor merged 1 commit into
mainfrom
fix/no-dump-data-defined-for-proc
Jul 7, 2026
Merged

Fix exception caused when marshalling models#746
phylor merged 1 commit into
mainfrom
fix/no-dump-data-defined-for-proc

Conversation

@phylor

@phylor phylor commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Fixes exception: no _dump_data is defined for class Proc

Occurs when Ioki models are involved in caching, and therefore marshalled. Until now we created the deprecator on every model, but it should in fact live on the gem module instead.

For non-Rails projects, we use Kernel as a deprecator. We only call warn on the deprecator, which also exists on Kernel.

Exception: no _dump_data is defined for class Proc
@phylor phylor requested review from rmehner and tom-ioki July 6, 2026 13:08

@tom-ioki tom-ioki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a reasonable change 👍 Thank you!

@phylor phylor merged commit 7e54f29 into main Jul 7, 2026
2 checks passed
@phylor phylor deleted the fix/no-dump-data-defined-for-proc branch July 7, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants