-
Notifications
You must be signed in to change notification settings - Fork 13.3k
fix(checkbox,radio,toggle): add missing keyboard focus indicators #31295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShaneK
wants to merge
14
commits into
main
Choose a base branch
from
FW-7585-FW-7586
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
33e40af
fix(checkbox,radio): show keyboard focus indicator, including in mult…
ShaneK 81736bf
fix(toggle): show keyboard focus indicator via focusable track ring
ShaneK a135348
fix(checkbox,radio,toggle): hide native focus ring on focused controls
ShaneK 5953965
test(checkbox,toggle): capture focus indicator via real keyboard focu…
ShaneK 1568d4a
chore(test): trying to minimize screenshot width
ShaneK 409a0ba
chore(): add updated snapshots
Ionitron 6a3c199
Bdocs(checkbox,radio): add multi-input item focus demo to item test p…
ShaneK 084902b
Merge branch 'FW-7585-FW-7586' of github.com:ionic-team/ionic-framewo…
ShaneK a105ea7
test(checkbox,radio,toggle): add checked/md focus and multi-input ite…
ShaneK c00892d
chore(lint): fixing lint
ShaneK fc10735
chore(): add updated snapshots
Ionitron 1c38112
Merge branch 'FW-7585-FW-7586' of github.com:ionic-team/ionic-framewo…
ShaneK 910cddb
test(checkbox,radio): add multi-input item focus screenshots and fix …
ShaneK edcfb72
chore(): add updated snapshots
Ionitron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.