chore(vue-router): upgrade vue-router to 5.2.0, vite to ^8 - #31300
Open
ShaneK wants to merge 2 commits into
Open
chore(vue-router): upgrade vue-router to 5.2.0, vite to ^8#31300ShaneK wants to merge 2 commits into
ShaneK wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
@ionic/vue-router,@ionic/vue, and the vue3 test app pinvue-routerat5.0.6. The test app's dev and test toolchain is also several majors behind: vite 3, vitest 1,@vue/test-utils2.0.0-rc.18, and jsdom 20.vue-router 5.1+ declares an optional peer on
vite ^7 || ^8(for its experimental typed-routes unplugin), which the vite 3 pin can't satisfy. So bumping vue-router on its own forces--legacy-peer-depson every test app install.What is the new behavior?
This bumps
vue-routerto5.2.0across@ionic/vue-router,@ionic/vue, and the vue3 test app. The wrapper needed no source changes: every vue-router API it imports (createRouter,createWebHistory,parseQuery,RouteLocationNormalized, and so on) is unchanged between 5.0.6 and 5.2.0. The 5.1 and 5.2 changes target the experimental typed-routes unplugin, scrollBehavior, and some other stuff Ionic doesn't use.It also modernizes the test app toolchain to vite 8, vitest 4,
@vitejs/plugin-vue6,@vue/test-utils2.4.11, and jsdom 30, and raises the app's Node engine floor to match. With vite on 8, vue-router's optional vite peer now resolves on its own, so the install no longer needs--legacy-peer-deps.Also fixing a flaky playwright test
Does this introduce a breaking change?
Other information