Remove screenshot test PR comment workflow; replace with inline CI error and retries

[Copilot]

The screenshot-test-comment.yml workflow (pull_request_target) always failed on first run for fork PRs because the workflow requires manual approval before running — meaning the screenshot test it was waiting on hadn't run yet.

Changes

• Deleted .github/workflows/screenshot-test-comment.yml — removes the fragile PR comment workflow entirely
• Added a Report Screenshot Test failure step to the ScreenshotTests job in main.yml using the ::error:: workflow command, following the same pattern already used by JavadocDoclint:

- name: Report Screenshot Test failure
  if: failure()
  run: |
    echo "::error title=Screenshot tests failed::Screenshot tests have failed.%0A%0A"\
    "To review the differences:%0A"\
    "  1. Download the 'screenshot-test-report' artifact from this run.%0A"\
    ...

The error message preserves the key guidance from the old PR comment: how to download the report artifact, what to do for unintentional vs. intentional visual changes, and a link to the README.

• Added retry logic to desktop screenshot tests (main.yml) — the Gradle test task is retried up to 3 times before the job is marked as failed, reducing noise from transient failures.
• Added retry logic to Android screenshot tests (android-screenshot.yml) — the connectedDebugAndroidTest Gradle task is similarly retried up to 3 times, with an adb uninstall before each attempt to ensure a clean state. The job timeout was increased from 20 to 60 minutes to accommodate the retries.

[riccardobl]

@copilot can you make screenshot tests retry up to 3 times if they fails before marking the workflow as failed?

[Copilot]

@copilot can you make screenshot tests retry up to 3 times if they fails before marking the workflow as failed?

Done — the Test with Gradle Wrapper step now loops up to 3 times, exiting immediately on success and only failing the job after all 3 attempts are exhausted. Committed in 8a3fe26.

[riccardobl]

@copilot can you do the same for android tests?

[Copilot]

@copilot can you do the same for android tests?

Done — the Android test script now retries the connectedDebugAndroidTest Gradle task up to 3 times (with an adb uninstall before each attempt for a clean state), and only exits with a failure after all 3 attempts. The job timeout was also bumped from 20 to 60 minutes to accommodate the retries. Committed in the latest push.

[riccardobl]

@copilot looks like something is wrong with the android task

/usr/bin/sh -c curl -L https://maven.google.com/androidx/test/services/test-services/1.6.0/test-services-1.6.0.apk --output test-services-1.6.0.apk
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   303  100   303    0     0   3068      0 --:--:-- --:--:-- --:--:--  3091

100  970k  100  970k    0     0  3461k      0 --:--:-- --:--:-- --:--:-- 3461k
/usr/bin/sh -c adb install -r -g test-services-1.6.0.apk
Performing Streamed Install
Success
/usr/bin/sh -c exit_code=1
/usr/bin/sh -c for attempt in 1 2 3; do
/usr/bin/sh: 1: Syntax error: end of file unexpected (expecting "done")
Error: The process '/usr/bin/sh' failed with exit code 2
Terminate Emulator
USER_INFO    | Snapshots have been disabled by the user, save request is ignored.
INFO         | Saving snapshot 'default_boot' using 0 ms
ERROR        | stop: Not implemented
WARNING      | Emulator client has not yet been configured.. Call configure me first!
INFO         | removeAll
WARNING      | Netsim Wifi localhost:42563 is gone due to CANCELLED

[Copilot]

@copilot looks like something is wrong with the android task

...

Fixed — the root cause was that reactivecircus/android-emulator-runner runs each line of the script: block as a separate /usr/bin/sh -c invocation, which breaks multi-line constructs like for loops. The retry logic is now written to android-test-script.sh in a prior run: step, and the emulator runner simply calls bash android-test-script.sh as a single line.