Warn when mipmap generation falls back to CPU#2873
Open
Copilot wants to merge 2 commits into
Open
Conversation
When the texture format does not support GPU-side mipmap generation (not both colorRenderable and filterable) and the system successfully falls back to CPU mipmap generation, log a WARNING to inform the developer of the fallback and which format caused it. Fixes: https://github.com/jMonkeyEngine/jmonkeyengine/issues/...
Copilot
AI
changed the title
[WIP] Print warning when mipmap generation falls back to CPU generation
Warn when mipmap generation falls back to CPU
Jun 11, 2026
riccardobl
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a texture format is not both color-renderable and filterable,
glGenerateMipmapcannot be used and the renderer silently falls back to CPU-side mipmap generation. Developers had no visibility into this performance-relevant fallback.Changes
GLRenderer.updateTexImageData()— adds aLevel.WARNINGlog when CPU mipmap fallback succeeds, identifying the texture and the unsupported format:The warning fires only once per texture (gated by the existing
textureWasUnuploadedguard), so there is no log spam on repeated frames.