Add rules replacing call-with-output-file with display-to-file#793
Merged
Conversation
Adds two rules to the file-io-suggestions suite. A call-with-output-file expression whose procedure just displays a value to the port is rewritten to display-to-file, and one whose procedure consists of displayln calls is rewritten to display-lines-to-file. The rules only fire when the port is used as nothing but the last argument of the display calls, and Resyntax's existing binding correctness check discards the suggestions in modules that don't import racket/file. Fixes #673. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Resyntax analyzed 2 files in this pull request and found no issues.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
coverage: 93.931% (+0.04%) from 93.896% — manual-display-to-file-rule into master |
Contributor
There was a problem hiding this comment.
Resyntax analyzed 2 files in this pull request and found no issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #673.