Add RootFS license/NOTICE candidate bundle#27
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aaf3618b18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| rescue ArgumentError, URI::InvalidURIError, SocketError, SystemCallError, | ||
| Timeout::Error, OpenSSL::SSL::SSLError => error |
There was a problem hiding this comment.
Handle Net::HTTP connection errors before trying fallback URLs
When an HTTPS proxy rejects the CONNECT request or Net::HTTP encounters a protocol-level failure, Net::HTTP.start can raise Net::HTTPClientException/Net::HTTPFatalError, which this rescue list does not convert to BundleError. Consequently, fetch_remote_payload cannot record the failure and try the next pinned URL, and the top-level handler emits an uncaught stack trace instead of a controlled materialization error. This occurs, for example, with a proxy returning HTTP 403 during connection setup.
Useful? React with 👍 / 👎.
Summary
Candidate payloads remain outside Git. Engineering review approval, legal review, and redistribution approval remain false.
Validation
swift test(139 tests, 1 expected skip, 0 failures)git diff --check