Fix provision logging user back out after successful sign-in#29294
Merged
Conversation
resetState rewinds startProvisionTrigger 1->0, which subscribeValue treats as a change and re-fires onStartProvisionTriggerChanged. After a successful provision (loggedIn now true) that handler logs the just-provisioned user back out, leaving them stuck on the login screen. Guard the handler to only run on an increment (a real provision start), ignoring the reset-to-0 rewind.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an unintended logout after a successful provisioning/sign-in by preventing the “start provision” subscription handler from running when the provision store trigger is rewound during resetState/resetAllStores.
Changes:
- Update
onStartProvisionTriggerChangedto receive(value, previous)from the sharedsubscribeValuehelper. - Guard the handler so it only runs when
startProvisionTriggerincrements (a real provision start), and ignores resets that decrease the trigger back to0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resetState rewinds startProvisionTrigger 1->0, which subscribeValue treats as a change and re-fires onStartProvisionTriggerChanged. After a successful provision (loggedIn now true) that handler logs the just-provisioned user back out, leaving them stuck on the login screen.
Guard the handler to only run on an increment (a real provision start), ignoring the reset-to-0 rewind.