perf: fix chat re-render hotspots, drop react-compiler bailouts#29299
Merged
Conversation
Chat thread rows: split center-context into state/actions contexts so action-only consumers skip highlight re-renders, subscribe to derived isEditing instead of the raw editing ordinal, replace the per-row team-members hook with a context-only role lookup, compute separator orange-line labels only when shown, and merge the duplicated useMessageData hooks. The react compiler bailed out of 81 components/hooks — notably the markdown component, which re-parsed on every text row render. Move try/catch/finally, ??=, getters, dynamic imports, and render-time require()d hooks out of compiled function bodies; opt vendored zoom-toolkit out via 'use no memo'. Now 0 bailouts repo-wide. Add yarn lint:bailouts (scripts/react-compiler-bailouts.mts) and yarn lint:all (eslint + bailouts + tsc). eslint cannot report Todo-category bailouts, so the script is the only guard against new ones. Also fix shared-timers _removeTimer off-by-one that never cleared the first timer.
- useSafeFocusEffect: run cleanups returned by fn, clean up on blur - react-compiler-bailouts: fail --check on parse failures, fix message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat thread rows: split center-context into state/actions contexts so action-only consumers skip highlight re-renders, subscribe to derived isEditing instead of the raw editing ordinal, replace the per-row team-members hook with a context-only role lookup, compute separator orange-line labels only when shown, and merge the duplicated useMessageData hooks.
The react compiler bailed out of 81 components/hooks — notably the markdown component, which re-parsed on every text row render. Move try/catch/finally, ??=, getters, dynamic imports, and render-time require()d hooks out of compiled function bodies; opt vendored zoom-toolkit out via 'use no memo'. Now 0 bailouts repo-wide.
Add yarn lint:bailouts (scripts/react-compiler-bailouts.mts) and yarn lint:all (eslint + bailouts + tsc). eslint cannot report Todo-category bailouts, so the script is the only guard against new ones.
Also fix shared-timers _removeTimer off-by-one that never cleared the first timer.