Skip to content

Fix basicpipeline-semver e2e expected output for set-labels v0.2.5#4605

Merged
liamfallon merged 1 commit into
kptdev:mainfrom
Nordix:update-basicpipeline-semver-expected-output
Jul 1, 2026
Merged

Fix basicpipeline-semver e2e expected output for set-labels v0.2.5#4605
liamfallon merged 1 commit into
kptdev:mainfrom
Nordix:update-basicpipeline-semver-expected-output

Conversation

@aravindtga

Copy link
Copy Markdown
Contributor

Description

  • What changed: Updated the expected diff patch for the basicpipeline-semver e2e test to reflect the new resolved version of set-labels (v0.2.4v0.2.5) and the corresponding git index hash.
  • Why it's needed: The set-labels function was released as v0.2.5 in the krm-functions-catalog. Since the test uses a semver range constraint (~0.2), the resolved image tag now picks up v0.2.5, causing the e2e test to fail against the old expected output.
  • How it works: The expected diff patch file is updated to match the current resolved output.

Type of Change

  • Tests
  • Bug fix

Checklist

  • Code follows project style guidelines
  • Self-reviewed changes
  • Tests added/updated
  • Documentation added/updated
  • All tests and gating checks pass

AI Disclosure

  • I have used AI in the creation of this PR.

If so, please describe how:
- Kiro to generate the PR message.

@netlify

netlify Bot commented Jun 30, 2026

Copy link
Copy Markdown

Deploy Preview for kptdocs ready!

Name Link
🔨 Latest commit c4c69ce
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/6a44089f742e7d0008d6f2f9
😎 Deploy Preview https://deploy-preview-4605--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
@aravindtga aravindtga force-pushed the update-basicpipeline-semver-expected-output branch from 8249da7 to c4c69ce Compare June 30, 2026 18:19
@aravindtga aravindtga self-assigned this Jun 30, 2026
@aravindtga aravindtga requested a review from Copilot June 30, 2026 18:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the basicpipeline-semver function-render e2e golden diff to match the newly resolved set-labels function version (v0.2.5) selected by the existing ~0.2 semver constraint, fixing the test expectation drift caused by the catalog release.

Changes:

  • Bumps the expected rendered image reference from set-labels:v0.2.4 to set-labels:v0.2.5 in the golden diff patch.
  • Updates the expected Kptfile diff header index hash accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aravindtga aravindtga marked this pull request as ready for review June 30, 2026 18:26
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. Testing labels Jun 30, 2026
@aravindtga aravindtga requested review from a team June 30, 2026 18:26

@liamfallon liamfallon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is why the dependabot PR is failing

@liamfallon liamfallon merged commit f9de6de into kptdev:main Jul 1, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size:XS This PR changes 0-9 lines, ignoring generated files. Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants