Fix readline_channel crash and None return on default timeout#2622
Merged
kubernetes-prow[bot] merged 2 commits intoJul 7, 2026
Merged
Conversation
Signed-off-by: Artem Muterko <artem@sopho.tech>
Signed-off-by: Artem Muterko <artem@sopho.tech>
kubernetes-prow
Bot
added
release-note
Contributor
|
thanks for the PR /lgtm |
kubernetes-prow
Bot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: archy-rock3t-cloud, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
approved
kubernetes-prow
Bot
merged commit 8a16f86
into
kubernetes-client:master
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
With the default timeout, readline_channel converted None to float("inf") and crashed in update() when it reached select.poll().poll(). An infinite timeout now maps to a blocking poll, and an expired finite timeout returns '' or b'' like the other read methods instead of None.
Which issue(s) this PR fixes:
Fixes #2621
Does this PR introduce a user-facing change?