docs(review-flows skill): daemon prerequisite, roles, and failure handling#218
docs(review-flows skill): daemon prerequisite, roles, and failure handling#218realtonyyoung wants to merge 1 commit into
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
realtonyyoung
left a comment
There was a problem hiding this comment.
Found one documentation correctness issue in the new failure-handling guidance. The rest of the added sections look consistent with the flow tool surface, the daemon launch path, and PR #217 auto-registration wording.
|
Fixed in
Docs-only; no CLI surface change. |
…us failure handling Rebased onto current main (which #235/#238 rewrote for opt-in gating and the hosted-reviewer misfire guard, and #233/#234 made hosting vendor-uniform). Dropped my earlier "Roles" section (now covered by main's intro + "when NOT to use" gating) and the Codex-specific wording (reviewer vendor now comes from the flow definition, not hardcoded Codex). Remaining unique, vendor-neutral addition: a Prerequisites section stating start_review_flow needs `kcap login` + a daemon with this repo checked out, and split failure handling — no-daemon (start one, retry) vs ambiguous multi-checkout match (can't disambiguate; surface it, AI-1112). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1039c4d to
20ced66
Compare
|
Rebased onto current Given those, I trimmed this PR rather than force my original text back in:
What remains is the still-unique, vendor-neutral bit Now |
What
Enhances the
review-flowsskill (kcap/skills/review-flows/SKILL.md) so the driving agent knows what has to be true for a flow to work, and what to do when it isn't.kcapdaemon (never configured from the driver).start_review_flowneedskcap loginand a running daemon with this repo checked out, or it errors instead of returning aflow_run_id.kcap daemon start -dwith the target repo) rather than retrying blindly; don't start a flow (which spends real reviewer compute) unprompted.Why
Setting the feature up end-to-end surfaced that these prerequisites were undocumented on the agent-facing surface — the skill explained the loop mechanics but not the daemon dependency or the driver/reviewer split, so an agent hitting a no-daemon error had no guidance.
Scope / relationship to other work
Doc-only; no CLI surface change (no new command/flag), so no README sync is required by the repo convention.
Complements #217 (AI-1056), which auto-registers the flows MCP server for Claude Code and rewrites the README/registration guidance. This PR touches only
SKILL.md(which #217 does not), so the two don't conflict.Linear: AI-774 (feature), AI-1056 (auto-register follow-up).