feat: add FDv2 configuration builder#545
Open
beekld wants to merge 51 commits into
Open
Conversation
cce4172 to
458539d
Compare
458539d to
5aace2f
Compare
095280a to
58392f8
Compare
5aace2f to
5988ce1
Compare
5988ce1 to
88190bc
Compare
…verride in FDv2Builder
88190bc to
86b2e3d
Compare
beekld
added a commit
that referenced
this pull request
Jun 12, 2026
beekld
added a commit
that referenced
this pull request
Jun 12, 2026
beekld
added a commit
that referenced
this pull request
Jun 12, 2026
kinyoklion
reviewed
Jun 16, 2026
| class Streaming { | ||
| public: | ||
| Streaming& InitialReconnectDelay(std::chrono::milliseconds delay); | ||
| Streaming& Filter(std::string filter_key); |
Member
There was a problem hiding this comment.
The FDv2 endpoints don't support filters as far as I am aware. Instead we are depending on view keys.
Contributor
Author
There was a problem hiding this comment.
Maybe I'm misunderstanding. Isn't that what these are?
kinyoklion
reviewed
Jun 16, 2026
kinyoklion
approved these changes
Jun 16, 2026
beekld
added a commit
that referenced
this pull request
Jun 16, 2026
beekld
added a commit
that referenced
this pull request
Jun 16, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 13bdf20. Configure here.
# Conflicts: # libs/server-sdk/src/client_impl.cpp
beekld
added a commit
that referenced
this pull request
Jun 16, 2026
beekld
added a commit
that referenced
this pull request
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds a public
FDv2Builderand wires the FDv2 data system intoMakeDataSystem, so end users can opt into the FDv2 protocol via the existing config-builder pattern.Test plan
config_builder_test.cppNote
Medium Risk
Changes how the client selects and instantiates flag data sources (new FDv2 path and factory wiring); misconfiguration could affect connectivity and fallback behavior, though default remains background sync.
Overview
FDv2 is now a selectable data system via
DataSystemBuilder::Method(FDv2Builder), alongside background sync and lazy load. PublicFDv2Builder(Default()/Custom()) configures polling initializers, ordered streaming/polling synchronizers, optional FDv1 fallback, and fallback/recovery timeouts; built config addsFDv2Configwith per-source filter andBaseUrloverrides.Runtime wiring:
MakeDataSystemconstructsFDv2DataSystemthrough new initializer and synchronizer factories (FDv2 polling/streaming plus FDv1 adapter factories). FDv2 poll/stream components now take a resolved base URL string (override or service endpoints) instead of fullServiceEndpoints.Tests cover FDv2 builder defaults, synchronizer ordering, FDv1 fallback, timeouts, and base URL overrides; existing FDv2 HTTP tests updated for the new poll-request API.
Reviewed by Cursor Bugbot for commit 45f5926. Bugbot is set up for automated code reviews on this repo. Configure here.