Skip to content

feat: expose Big Segments via public Client and Config APIs#552

Merged
beekld merged 5 commits into
mainfrom
beeklimt/SDK-2368
Jun 16, 2026
Merged

feat: expose Big Segments via public Client and Config APIs#552
beekld merged 5 commits into
mainfrom
beeklimt/SDK-2368

Conversation

@beekld

@beekld beekld commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Expose Big Segments to customer code

Makes the server-side Big Segments feature reachable from customer code: a public config method to wire a store, and a status provider on the client for querying store health and subscribing to changes. Builds on SDK-2366-2.

What's in

  • Promotes BigSegmentsBuilder to the public include tree and adds ConfigBuilder::BigSegments(BigSegmentsBuilder), surfaced as an optional Config::BigSegments().
  • New public IBigSegmentStoreStatusProvider and BigSegmentStoreStatus (IsAvailable()/IsStale()), plus Client::BigSegmentStoreStatus().
  • ClientImpl constructs the BigSegmentStoreWrapper from config, hands it to the evaluator, and starts its background poll. An internal adapter exposes the wrapper's status broadcaster as the public provider.
  • BigSegmentsBuilder::Build() now returns a new error code when the store is null.

Design notes

  • The status surface mirrors DataSourceStatus: the accessor is Status(), and listeners use OnBigSegmentStoreStatusChange(handler) -> IConnection.
  • When no store is configured, the provider reports the store as unavailable and registered listeners never fire.

Testing

Unit tests added for the new behavior.


Note

Medium Risk
Changes flag evaluation wiring and add a new public config surface; misconfiguration or store outages can affect Big Segment targeting, though behavior is gated on optional config and mirrors existing data-source status patterns.

Overview
This PR wires Big Segments into the public server SDK: customers can attach a store via config and observe store health on the client, similar to data source status.

Configuration: ConfigBuilder::BigSegments(BigSegmentsBuilder) stores an optional BigSegmentsConfig on Config. BigSegmentsBuilder::Build() now returns tl::expected and fails with kConfig_BigSegments_NullStore when the store pointer is null (previously a null store was allowed through).

Client runtime: When Big Segments are configured, ClientImpl creates BigSegmentStoreWrapper, passes it to the evaluator, starts background metadata polling, and exposes status through Client::BigSegmentStoreStatus().

Public status API: New BigSegmentStoreStatus (IsAvailable / IsStale) and IBigSegmentStoreStatusProvider with Status() and OnBigSegmentStoreStatusChangeIConnection. An internal adapter maps the wrapper to this API; with no store configured, status is unavailable/not stale and listeners are no-ops.

Unit tests cover builder validation, config round-trip, and status provider behavior (including transitions).

Reviewed by Cursor Bugbot for commit 11902fa. Bugbot is set up for automated code reviews on this repo. Configure here.

@beekld beekld force-pushed the beeklimt/SDK-2368 branch from 7153392 to 53139f4 Compare June 12, 2026 16:45
Base automatically changed from beeklimt/SDK-2366-2 to main June 12, 2026 19:04
@beekld beekld force-pushed the beeklimt/SDK-2368 branch from 53139f4 to 5836643 Compare June 12, 2026 19:09
@beekld beekld marked this pull request as ready for review June 12, 2026 19:10
@beekld beekld requested a review from a team as a code owner June 12, 2026 19:10
@beekld beekld force-pushed the beeklimt/SDK-2368 branch 2 times, most recently from d9c101f to 8ff748b Compare June 15, 2026 23:25
return wrapper_->OnStatusChange(
[handler = std::move(handler)](
data_components::BigSegmentStoreStatus status) {
handler(ToPublic(status));

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need some exception wrapping around the handler?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the other public APIs that take callbacks seem to wrap the handlers, so I don't think so. We could do a pass and add it to all of them if we think it's a good idea.

@beekld beekld force-pushed the beeklimt/SDK-2368 branch from 8ff748b to 11902fa Compare June 16, 2026 18:29
@beekld beekld merged commit c5fd239 into main Jun 16, 2026
47 checks passed
@beekld beekld deleted the beeklimt/SDK-2368 branch June 16, 2026 19:06
@github-actions github-actions Bot mentioned this pull request Jun 16, 2026
beekld added a commit that referenced this pull request Jun 16, 2026
# Conflicts:
#	libs/server-sdk/src/client_impl.cpp
beekld added a commit that referenced this pull request Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants