feat: expose Big Segments via public Client and Config APIs#552
Merged
Conversation
7153392 to
53139f4
Compare
53139f4 to
5836643
Compare
d9c101f to
8ff748b
Compare
kinyoklion
reviewed
Jun 16, 2026
| return wrapper_->OnStatusChange( | ||
| [handler = std::move(handler)]( | ||
| data_components::BigSegmentStoreStatus status) { | ||
| handler(ToPublic(status)); |
Member
There was a problem hiding this comment.
Do we need some exception wrapping around the handler?
Contributor
Author
There was a problem hiding this comment.
None of the other public APIs that take callbacks seem to wrap the handlers, so I don't think so. We could do a pass and add it to all of them if we think it's a good idea.
kinyoklion
approved these changes
Jun 16, 2026
8ff748b to
11902fa
Compare
beekld
added a commit
that referenced
this pull request
Jun 16, 2026
# Conflicts: # libs/server-sdk/src/client_impl.cpp
beekld
added a commit
that referenced
this pull request
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose Big Segments to customer code
Makes the server-side Big Segments feature reachable from customer code: a public config method to wire a store, and a status provider on the client for querying store health and subscribing to changes. Builds on SDK-2366-2.
What's in
BigSegmentsBuilderto the public include tree and addsConfigBuilder::BigSegments(BigSegmentsBuilder), surfaced as an optionalConfig::BigSegments().IBigSegmentStoreStatusProviderandBigSegmentStoreStatus(IsAvailable()/IsStale()), plusClient::BigSegmentStoreStatus().ClientImplconstructs theBigSegmentStoreWrapperfrom config, hands it to the evaluator, and starts its background poll. An internal adapter exposes the wrapper's status broadcaster as the public provider.BigSegmentsBuilder::Build()now returns a new error code when the store is null.Design notes
DataSourceStatus: the accessor isStatus(), and listeners useOnBigSegmentStoreStatusChange(handler) -> IConnection.Testing
Unit tests added for the new behavior.
Note
Medium Risk
Changes flag evaluation wiring and add a new public config surface; misconfiguration or store outages can affect Big Segment targeting, though behavior is gated on optional config and mirrors existing data-source status patterns.
Overview
This PR wires Big Segments into the public server SDK: customers can attach a store via config and observe store health on the client, similar to data source status.
Configuration:
ConfigBuilder::BigSegments(BigSegmentsBuilder)stores an optionalBigSegmentsConfigonConfig.BigSegmentsBuilder::Build()now returnstl::expectedand fails withkConfig_BigSegments_NullStorewhen the store pointer is null (previously a null store was allowed through).Client runtime: When Big Segments are configured,
ClientImplcreatesBigSegmentStoreWrapper, passes it to the evaluator, starts background metadata polling, and exposes status throughClient::BigSegmentStoreStatus().Public status API: New
BigSegmentStoreStatus(IsAvailable/IsStale) andIBigSegmentStoreStatusProviderwithStatus()andOnBigSegmentStoreStatusChange→IConnection. An internal adapter maps the wrapper to this API; with no store configured, status is unavailable/not stale and listeners are no-ops.Unit tests cover builder validation, config round-trip, and status provider behavior (including transitions).
Reviewed by Cursor Bugbot for commit 11902fa. Bugbot is set up for automated code reviews on this repo. Configure here.