Powf to powi#307
Open
drobnyjt wants to merge 5 commits into
Open
Conversation
Collaborator
Author
|
This PR also fixes some default initial ion positions in the Python API - they were erroneously converted from meters to angstroms with 10e30 instead of 1e30 - this does not have a measurable effect on the vast majority of simulations which is how it had been missed for so long, but if someone were using reflection_coefficient for sub-eV simulations (which is explicitly not recommended) it could have an effect on results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to rustBCA!
Before submitting this PR, please make sure you have:
Fixes #306
Description
This draft PR replaces all unnecessary powf invocations with appropriate alternatives.
Tests
cargo test has been run; I'll use CI to run integration tests and check output is unchanged.