Skip to content

feat(samples/kotlin): support GRID_API_BASE_URL override #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pengying wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

feat(samples/kotlin): support GRID_API_BASE_URL override #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion samples/kotlin/src/main/kotlin/com/grid/sample/Config.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,16 @@ object Config {
val apiClientSecret: String = getEnvVar("GRID_CLIENT_SECRET")
val webhookPublicKey: String = getEnvVar("GRID_WEBHOOK_PUBKEY").replace("\\n", "\n")

// Optional override for the Grid API base URL (e.g. a dev/RC environment).
// When unset, the SDK uses its default (production) base URL.
val apiBaseUrl: String? = getEnvVarOrNull("GRID_API_BASE_URL")

@greptile-apps greptile-apps Bot Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Empty string not treated as "unset"

getEnvVarOrNull returns an empty string if GRID_API_BASE_URL is set to "" (e.g. an accidentally blank .env entry). That empty string is non-null, so apiBaseUrl will be "" and baseUrl("") will be called on the SDK builder — almost certainly producing a malformed URL at runtime instead of silently falling back to the default.

Suggested change
val apiBaseUrl: String? = getEnvVarOrNull("GRID_API_BASE_URL")
val apiBaseUrl: String? = getEnvVarOrNull("GRID_API_BASE_URL")?.takeIf { it.isNotBlank() }
Prompt To Fix With AI 
This is a comment left during a code review.
Path: samples/kotlin/src/main/kotlin/com/grid/sample/Config.kt
Line: 18

Comment:
**Empty string not treated as "unset"**

`getEnvVarOrNull` returns an empty string if `GRID_API_BASE_URL` is set to `""` (e.g. an accidentally blank `.env` entry). That empty string is non-null, so `apiBaseUrl` will be `""` and `baseUrl("")` will be called on the SDK builder — almost certainly producing a malformed URL at runtime instead of silently falling back to the default.

```suggestion
    val apiBaseUrl: String? = getEnvVarOrNull("GRID_API_BASE_URL")?.takeIf { it.isNotBlank() }
```

How can I resolve this? If you propose a fix, please make it concise.


private fun getEnvVar(key: String): String =
getEnvVarOrNull(key)
?: throw IllegalStateException("$key environment variable not set")

private fun getEnvVarOrNull(key: String): String? =
System.getProperty(key)
?: dotenv[key]
?: System.getenv(key)
?: throw IllegalStateException("$key environment variable not set")
}
1 change: 1 addition & 0 deletions samples/kotlin/src/main/kotlin/com/grid/sample/GridClientBuilder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ object GridClientBuilder {
LightsparkGridOkHttpClient.builder()
.username(Config.apiTokenId)
.password(Config.apiClientSecret)
.apply { Config.apiBaseUrl?.let { baseUrl(it) } }
.build()
}
}
Loading