Map SGD accounts to not require bank name#608
Closed
JasonCWang wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
github-actions
Bot
added
the
breaking-change
Contributor
|
Contributor
✱ Stainless preview builds for gridThis PR will update the cli csharp go kotlin openapi php python ruby typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-cli studio · code · diff
✅ grid-go studio · code · diff
✅ grid-openapi studio · code · diff
✅ grid-ruby studio · code · diff
✅ grid-kotlin studio · code · diff
✅ grid-python studio · code · diff
✅ grid-csharp studio · code · diff
✅ grid-php studio · code · diff
✅ grid-typescript studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Contributor
Greptile SummaryRelaxes the
Confidence Score: 5/5This is a straightforward schema relaxation — removing a required field constraint — with no logic changes and all three files (source + both generated bundles) consistently updated. The change is a single-field constraint removal applied identically across the source YAML and both generated bundles, confirming make build was executed. The field itself remains defined and usable as optional. No functional logic, auth, or data-path code is touched. No files require special attention.
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/common/SgdAccountInfoBase.yaml | Removes bankName from the required array, making it an optional field; field definition and example remain unchanged. |
| openapi.yaml | Generated bundle correctly reflects the source change — bankName removed from SgdAccountInfoBase.required. |
| mintlify/openapi.yaml | Mintlify-specific generated bundle correctly reflects the same bankName requirement removal. |
Class Diagram
%%{init: {'theme': 'neutral'}}%%
classDiagram
class SgdAccountInfoBase {
+string accountType (required)
+string accountNumber (required)
+string swiftCode (required)
+string bankName (optional)
}
class SgdAccountInfo {
+string[] paymentRails (required)
}
SgdAccountInfoBase <|-- SgdAccountInfo : allOf
note for SgdAccountInfoBase "bankName was required\nnow it is optional"
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
classDiagram
class SgdAccountInfoBase {
+string accountType (required)
+string accountNumber (required)
+string swiftCode (required)
+string bankName (optional)
}
class SgdAccountInfo {
+string[] paymentRails (required)
}
SgdAccountInfoBase <|-- SgdAccountInfo : allOf
note for SgdAccountInfoBase "bankName was required\nnow it is optional"
Reviews (1): Last reviewed commit: "Map SGD accounts to not require bank nam..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.