fix: improved code repo validation#1020
Open
dennisvankekem wants to merge 8 commits into
Open
Conversation
j-zimnowoda
reviewed
Jun 22, 2026
j-zimnowoda
reviewed
Jun 22, 2026
There was a problem hiding this comment.
Pull request overview
Improves APL code repository URL handling by normalizing external repository URLs (and using normalized URLs for duplicate detection), expanding unit tests around URL normalization/rejection, and updating the OpenAPI repoUrl schema pattern/description accordingly.
Changes:
- Normalize external
repositoryUrlvalues on create and compare normalized URLs to prevent duplicates across URL variants. - Update/extend
OtomiStacktests to cover URL normalization cases and reject unsupported SSH URL schemes. - Update OpenAPI
repoUrldescription/pattern to accept protocol-less/HTTPS repo URLs with optional.gitand trailing slash.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/otomi-stack.ts |
Normalizes external repo URLs before saving and uses normalization for duplicate URL checks. |
src/otomi-stack.test.ts |
Expands coverage to assert URL normalization behavior and rejection of unsupported SSH scheme input. |
src/openapi/definitions.yaml |
Updates repoUrl schema description and regex pattern to match new accepted URL formats. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
j-zimnowoda
reviewed
Jun 25, 2026
j-zimnowoda
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.