Skip to content

fix: improved code repo validation#1020

Open
dennisvankekem wants to merge 8 commits into
mainfrom
APL-1775-2
Open

fix: improved code repo validation#1020
dennisvankekem wants to merge 8 commits into
mainfrom
APL-1775-2

Conversation

@dennisvankekem

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/otomi-stack.ts
Comment thread src/otomi-stack.ts

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves APL code repository URL handling by normalizing external repository URLs (and using normalized URLs for duplicate detection), expanding unit tests around URL normalization/rejection, and updating the OpenAPI repoUrl schema pattern/description accordingly.

Changes:

  • Normalize external repositoryUrl values on create and compare normalized URLs to prevent duplicates across URL variants.
  • Update/extend OtomiStack tests to cover URL normalization cases and reject unsupported SSH URL schemes.
  • Update OpenAPI repoUrl description/pattern to accept protocol-less/HTTPS repo URLs with optional .git and trailing slash.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/otomi-stack.ts Normalizes external repo URLs before saving and uses normalization for duplicate URL checks.
src/otomi-stack.test.ts Expands coverage to assert URL normalization behavior and rejection of unsupported SSH scheme input.
src/openapi/definitions.yaml Updates repoUrl schema description and regex pattern to match new accepted URL formats.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/otomi-stack.ts
Comment thread src/otomi-stack.test.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants