poller: support different tree name and prefix#78
Conversation
The current code was assuming that the tree name and prefix were always the same, but that's not necessary the case. Instead, pass a list of Trees, so it is possible to access to both the name and prefix. Note: this modification requires an adaptation of the list module, e.g. for those not using the "netdev" modules. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
Or maybe we don't need this, and force the tree name and prefix to be identical. |
|
The two are probably mixed up in the code quite a bit because the prefix and name are the same in our deployment. I don't have a preference here TBH, but IIUC you're saying that we need to adjust the netdev matcher and that's not part of this PR? |
The netdev matcher is modified here, but not the wireless one. I should probably add this module to maintain it here, rather than on the side.
I think that was the only place, but yes, that's possible there are some other mix-ups. I can close this PR if that's easier. For the wireless one, I first did the modification, then I ended up modifying the config, that was easier. So that's not blocking for me not to have this PR. It's more for others, but having this close PR might be enough to document the known issue. |
2 participants
The current code was assuming that the tree name and prefix were always the same, but that's not necessary the case.
Instead, pass a list of Trees, so it is possible to access to both the name and prefix.
Note: this modification requires an adaptation of the list module, e.g. for those not using the "netdev" modules.
==> Are there many users of this list module? I guess no, but if yes, I can also modify the code to only pass the prefixes to
series_tree_name_direct()(instead of the names like before this PR), and then find the tree name associated to such prefix.