Skip to content

fix: wrong unassigned count#4230

Merged
ulemons merged 2 commits into
mainfrom
fix/wrong-unassigned-count
Jun 17, 2026
Merged

fix: wrong unassigned count#4230
ulemons merged 2 commits into
mainfrom
fix/wrong-unassigned-count

Conversation

@ulemons

@ulemons ulemons commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Wrong unassigned count fix

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Performance improvement
  • Chore / dependency update
  • Documentation

Note

Low Risk
Single SQL filter change in a read-only metrics query; no auth or write paths affected.

Overview
Fixes unassignedCritical in getOsspreyMetrics so dashboard metrics match how “unstewarded” critical packages are defined elsewhere.

The SQL COUNT(*) FILTER for unassigned critical packages now includes critical packages with no stewardship row, NULL stewardship status, or status unassigned, open, blocked, or inactive. Previously only missing stewardship or explicit unassigned counted, so open, blocked, inactive, and NULL-status rows were excluded from the metric.

Reviewed by Cursor Bugbot for commit ae8b51b. Bugbot is set up for automated code reviews on this repo. Configure here.

Signed-off-by: Umberto Sgueglia <usgueglia@contractor.linuxfoundation.org>
@ulemons ulemons self-assigned this Jun 17, 2026
Copilot AI review requested due to automatic review settings June 17, 2026 15:45
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Not ready to approve

The PR title shown (fix: wrong unassigned count) is missing the expected JIRA key, and there’s also a small query maintainability nit captured in the inline comment.

Pull request overview

Fixes an incorrect “unassigned critical packages” metric in the OSS packages data-access layer so the dashboard count matches stewardship-status grouping used elsewhere.

Changes:

  • Updates getOsspreyMetrics SQL aggregation for unassignedCritical to count critical packages whose stewardship is not in the “covered”/“escalated” statuses (or has no stewardship row).
File summaries
File Description
services/libs/data-access-layer/src/osspckgs/api.ts Adjusts the aggregate filter used to compute unassignedCritical in getOsspreyMetrics.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread services/libs/data-access-layer/src/osspckgs/api.ts Outdated
Signed-off-by: Umberto Sgueglia <usgueglia@contractor.linuxfoundation.org>
@ulemons ulemons merged commit 45554ae into main Jun 17, 2026
16 checks passed
@ulemons ulemons deleted the fix/wrong-unassigned-count branch June 17, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants