fix: wrong unassigned count#4230
Conversation
Signed-off-by: Umberto Sgueglia <usgueglia@contractor.linuxfoundation.org>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
There was a problem hiding this comment.
⚠️ Not ready to approve
The PR title shown (fix: wrong unassigned count) is missing the expected JIRA key, and there’s also a small query maintainability nit captured in the inline comment.
Pull request overview
Fixes an incorrect “unassigned critical packages” metric in the OSS packages data-access layer so the dashboard count matches stewardship-status grouping used elsewhere.
Changes:
- Updates
getOsspreyMetricsSQL aggregation forunassignedCriticalto count critical packages whose stewardship is not in the “covered”/“escalated” statuses (or has no stewardship row).
File summaries
| File | Description |
|---|---|
| services/libs/data-access-layer/src/osspckgs/api.ts | Adjusts the aggregate filter used to compute unassignedCritical in getOsspreyMetrics. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Umberto Sgueglia <usgueglia@contractor.linuxfoundation.org>
Summary
Wrong unassigned count fix
Type of change
Note
Low Risk
Single SQL filter change in a read-only metrics query; no auth or write paths affected.
Overview
Fixes
unassignedCriticalingetOsspreyMetricsso dashboard metrics match how “unstewarded” critical packages are defined elsewhere.The SQL
COUNT(*) FILTERfor unassigned critical packages now includes critical packages with no stewardship row, NULL stewardship status, or statusunassigned,open,blocked, orinactive. Previously only missing stewardship or explicitunassignedcounted, soopen,blocked,inactive, and NULL-status rows were excluded from the metric.Reviewed by Cursor Bugbot for commit ae8b51b. Bugbot is set up for automated code reviews on this repo. Configure here.