Skip to content

PlatformAudio#140

Merged
stephen-derosa merged 10 commits into
livekit:mainfrom
stephen-derosa:sderosa/BOT-377-platform-audio
Jun 10, 2026
Merged

PlatformAudio#140
stephen-derosa merged 10 commits into
livekit:mainfrom
stephen-derosa:sderosa/BOT-377-platform-audio

Conversation

@stephen-derosa

@stephen-derosa stephen-derosa commented May 27, 2026

Copy link
Copy Markdown
Collaborator

@stephen-derosa stephen-derosa self-assigned this May 27, 2026
Copilot AI review requested due to automatic review settings May 27, 2026 18:01
@stephen-derosa stephen-derosa marked this pull request as draft May 27, 2026 18:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new PlatformAudio API to expose WebRTC platform audio (ADM-backed capture/playout with voice processing) through the C++ SDK’s FFI layer, and wires it into LocalAudioTrack creation, with docs and unit coverage.

Changes:

  • Add public PlatformAudio / PlatformAudioSource API and FFI-backed implementation.
  • Add LocalAudioTrack::createLocalAudioTrack overload for PlatformAudioSource.
  • Add README documentation and new unit tests for platform audio behavior.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/tests/unit/test_platform_audio.cpp Adds unit tests covering default options, device info fields, and creating a track from a platform source.
src/platform_audio.cpp Implements PlatformAudio and PlatformAudioSource over synchronous FFI requests.
src/local_audio_track.cpp Adds shared helper for track creation and an overload accepting PlatformAudioSource.
README.md Documents recommended usage of PlatformAudio vs AudioSource, with a C++ example.
include/livekit/platform_audio.h Adds the public PlatformAudio API surface, options, device info, and error type with Doxygen docs.
include/livekit/local_audio_track.h Adds forward declaration + new overload and expands/updates Doxygen docs.
include/livekit/livekit.h Exposes platform_audio.h from the umbrella header.
CMakeLists.txt Adds src/platform_audio.cpp to the shared library build.
AGENTS.md Updates threading-model docs and adds PlatformAudio to the thread-safety table.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread AGENTS.md Outdated
Comment thread src/local_audio_track.cpp
Comment thread src/platform_audio.cpp Outdated
Comment thread src/platform_audio.cpp Outdated
@stephen-derosa stephen-derosa force-pushed the sderosa/BOT-377-platform-audio branch 2 times, most recently from 5a12680 to 9d3618c Compare June 2, 2026 02:37
Comment thread include/livekit/platform_audio.h
@stephen-derosa stephen-derosa marked this pull request as ready for review June 2, 2026 03:36
@stephen-derosa stephen-derosa changed the title Draft: Platform Audio Platform Audio Jun 2, 2026
@stephen-derosa stephen-derosa changed the title Platform Audio PlatformAudio Jun 2, 2026
@stephen-derosa stephen-derosa force-pushed the sderosa/BOT-377-platform-audio branch from ef9f1fe to a7d1829 Compare June 2, 2026 04:05

@xianshijing-lk xianshijing-lk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, it looks pretty good from a quick look.

Comment thread include/livekit/platform_audio.h
Comment thread include/livekit/local_audio_track.h Outdated
Comment thread include/livekit/local_audio_track.h Outdated
Comment thread include/livekit/local_audio_track.h
Comment thread include/livekit/platform_audio.h Outdated
Comment thread include/livekit/platform_audio.h Outdated
Comment thread src/tests/unit/test_platform_audio.cpp
Comment thread src/local_audio_track.cpp Outdated
Comment thread src/platform_audio.cpp Outdated
Comment thread src/platform_audio.cpp
Comment thread src/platform_audio.cpp Outdated
@stephen-derosa stephen-derosa force-pushed the sderosa/BOT-377-platform-audio branch 2 times, most recently from f4b7466 to 32bfa39 Compare June 3, 2026 18:26
Comment thread include/livekit/local_audio_track.h Outdated
@stephen-derosa stephen-derosa force-pushed the sderosa/BOT-377-platform-audio branch from 32bfa39 to 97a4b6d Compare June 4, 2026 17:55
@stephen-derosa stephen-derosa force-pushed the sderosa/BOT-377-platform-audio branch from 97a4b6d to 3ef5197 Compare June 8, 2026 19:51
Comment thread src/platform_audio.cpp Outdated
Comment thread src/platform_audio.cpp Outdated
@stephen-derosa stephen-derosa merged commit fea55c5 into livekit:main Jun 10, 2026
22 checks passed
@stephen-derosa stephen-derosa deleted the sderosa/BOT-377-platform-audio branch June 10, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants