release.sh: drop [skip ci] from version bump; allow manual tag_on_main#686
Open
bjorkert wants to merge 1 commit into
Open
release.sh: drop [skip ci] from version bump; allow manual tag_on_main#686bjorkert wants to merge 1 commit into
bjorkert wants to merge 1 commit into
Conversation
The [skip ci] on the version-bump commit skipped the required SwiftFormat lint check (blocking the release PRs) and the tag_on_main workflow (no auto-tag). Remove it; auto_version_dev already prevents re-bumping via its Config.xcconfig guard. Also add a workflow_dispatch trigger to tag_on_main so the tag can be created manually if a run is ever skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
[skip ci]on the release version-bump commit had two harmful side effects observed during the v6.2.0 release:BLOCKED(requiring a manual override to merge).v6.2.0tag was never created automatically and had to be pushed by hand.The
[skip ci]was only there to stopauto_version_devfrom re-bumping when the commit lands ondev— but that workflow already prevents this via its own "Skip if Config.xcconfig was changed in this push" guard. So the token is redundant for its intended purpose and is removed.Also adds a
workflow_dispatchtrigger totag_on_main.ymlas a safety net: if a tagging run is ever skipped, the tag can be created by dispatching the workflow againstmain(idempotent — it skips if the tag already exists).Note: once this is merged, the
SwiftFormatrequirement can safely be enabled formain(Phase 3) without blocking future release PRs.