docs(config): clarify BigQuery timeoutMs semantics - #336
Open
girishjeswani wants to merge 3 commits into
Open
Conversation
…lling; 0 = no timeout) Signed-off-by: Girish Jeswani <girish@credibledata.com>
1 task
Correct the BigQuery timeoutMs row: an unset, blank, non-numeric, or 0 value falls back to the 10-minute default, matching the connector change in malloydata/malloy#3010. Signed-off-by: Girish Jeswani <girish@credibledata.com>
Signed-off-by: Girish Jeswani <girish@credibledata.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to malloydata/malloy#3010, which changes what the BigQuery connection
timeoutMsbounds.Before that PR,
timeoutMsonly boundedjobTimeoutMs; the results-fetch waitwas hard-capped near six minutes no matter what was configured. After it,
timeoutMsbounds the total wait (the BigQuery job and the results-fetchpolling), so the existing "Query timeout in ms" description is arguably only
becoming fully true now.
This updates the BigQuery
timeoutMsrow to spell out:Per the cross-repo checklist in
malloyatpackages/malloy/src/connection/CONTEXT.md.