Bugfix - Fix Dropdown keyboard focus and hover/tabindex coupling#53
Closed
markmead wants to merge 1 commit into
Closed
Bugfix - Fix Dropdown keyboard focus and hover/tabindex coupling#53markmead wants to merge 1 commit into
markmead wants to merge 1 commit into
Conversation
Menus opened via mouse click or Enter/Space left every item at tabindex="-1", so keyboard users could open the menu but Tab would skip past it entirely. toggleMenu() now focuses the first item on open, matching the existing ArrowDown/ArrowUp behavior. Also stopped mouse hover from moving the roving tabindex target, since hover highlighting was already covered by the existing hover: classes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
hyperux | 00e5751 | Commit Preview URL Branch Preview URL |
Jul 03 2026, 10:12 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toggleMenu()now focuses the first menu item when it opens the menu, fixing a bug where menus opened via mouse click or Enter/Space on the trigger left every item attabindex="-1"(Tab would skip past the open menu entirely — only ArrowDown/ArrowUp previously set focus correctly).x-on:mouseenterhandlers driving the rovingtabindex/highlight in the Dropdown demo, so hovering with a mouse no longer relocates the keyboard tab stop. Visual hover highlighting is unaffected (already handled by the existinghover:bg-gray-100classes).toggleMenu()focus behavior in the Behavior Contract and Accessibility Notes sections ofdropdown.mdx, plus a note onrole="menu"semantics for nav-heavy menus.Test plan
pnpm lintpnpm check🤖 Generated with Claude Code