Change to inline-CASText simplification and wrapping of raw "strings"#1783
Open
aharjula wants to merge 1 commit into
Open
Change to inline-CASText simplification and wrapping of raw "strings"#1783aharjula wants to merge 1 commit into
aharjula wants to merge 1 commit into
Conversation
… simplification so that "flat" things are not simplified in advance, to ensure that the logic doing `{@...@}` injections of inline-CASText does not consider them as "strings" and apply extra SMLT on them.
This solution does not cover the use of `castext_concat()` or `castext_simplify()` on inline-CASText fragments, those can still turn "flat" content to "strings" and lead to extra SMLT that might affect areas that should nto be affected by SMLT.
Should you use those and the result needs to be protected from overt SMLT application, you can use the old `[[castext evaluated="..."/]]`-block which was the predeccor of the `{@...@}` injection shorthand. It will do a pure injection without any risk of extra SMLT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to fix the off application of SMLT in issue #1777.
Modifies inline-CASText simplification so that "flat" things are not simplified in advance, to ensure that the logic doing
{@...@}injections of inline-CASText does not consider them as "strings" and apply extra SMLT on them.This solution does not cover the use of
castext_concat()orcastext_simplify()on inline-CASText fragments; those can still turn "flat" content to "strings" and lead to extra SMLT that might affect areas that should not be affected by SMLT.Should you use those and the result needs to be protected from overt SMLT application, you can use the old
[[castext evaluated="..."/]]-block, which was the predecessor of the{@...@}injection shorthand. It will do a pure injection without any risk of extra SMLT.