Skip to content

Remove messy Destroy test clean-up in TestPartialStateJoin #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MadLittleMods wants to merge 4 commits into
base: main
Choose a base branch
from
+75 −206
Open

Remove messy Destroy test clean-up in TestPartialStateJoin #895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8924c7a
Remove `WithWaitForLeave`
MadLittleMods Jul 13, 2026
a68ec08
Remove `awaitPartialStateJoinCompletion` from `Destroy`
MadLittleMods Jul 13, 2026
49e76c8
Remove the need to `Destroy`
MadLittleMods Jul 13, 2026
4e36144
Remove `Destroy` usage
MadLittleMods Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions helpers/waiter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,13 @@ func (w *Waiter) Waitf(t ct.TestLike, timeout time.Duration, errFormat string, a
}
}

// Done returns a channel which is closed when Finish is called. It can be used
// in `select` statements where failing the test on a timeout (as Wait does) is
// not appropriate. Prefer `Wait`/`Waitf` otherwise.
func (w *Waiter) Done() <-chan bool {
return w.ch
}

// Finish will cause all goroutines waiting via Wait to stop waiting and return.
// Once this function has been called, subsequent calls to Wait will return immediately.
// To begin waiting again, make a new Waiter.
Expand Down
Loading
Loading