Fixed favicon and discord links#727
Merged
Merged
Conversation
The discord links, while they did point to the proper channel, were inaccessible to people not in the server. This still points to the proper server, but is accessible to newcomers. It does not however point to the channel.
|
|
||
| The sections below explain how to contribute to each category and how to raise a pull request. | ||
|
|
||
| ## How to Contribute Simple Changes |
Collaborator
There was a problem hiding this comment.
Please drop the change to this doc (ko) and the same document in the zh path. These get fixed automatically when round-tripped through our translation service.
|
|
||
| - Open a pull request against the specification repository: [https://github.com/mavlink/mavlink](https://github.com/mavlink/mavlink) | ||
| - Reach out to the community on [Discord](https://discord.com/channels/1022170275984457759/1022185868317966458) and the [mailing list](https://groups.google.com/forum/#!forum/mavlink) to raise awareness | ||
| - Reach out to the community on [Discord](https://discord.gg/dronecode) and the [mailing list](https://groups.google.com/forum/#!forum/mavlink) to raise awareness |
Collaborator
There was a problem hiding this comment.
This is good, but we want people to know the right channel. How about this.
Suggested change
| - Reach out to the community on [Discord](https://discord.gg/dronecode) and the [mailing list](https://groups.google.com/forum/#!forum/mavlink) to raise awareness | |
| - Reach out to the community on Discord ([create account](https://discord.gg/dronecode) then use [#mavlink-general](https://discord.com/channels/1022170275984457759/1022185868317966458) channel) and the [mailing list](https://groups.google.com/forum/#!forum/mavlink) to raise awareness |
Similar in the case below.
Contributor
Author
There was a problem hiding this comment.
I've updated it, let me know if it's fine for you!
|
|
||
| head: [ | ||
| ["link", { rel: "icon", href: "/en/favicon.ico" }], | ||
| ["link", { rel: "icon", href: "/favicon.ico" }], |
Contributor
Author
|
Thanks for the quick review! |
hamishwillee
approved these changes
Jul 15, 2026
hamishwillee
left a comment
hamishwillee
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @DespicableGoose ! Much appreciated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The discord links, while they did point to the proper channel, were inaccessible to people not in the server. This still points to the proper server, but is accessible to newcomers. It does not however point to the channel.