Add sparse matrix and scaling tests#486
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
===========================================
- Coverage 82.99% 54.22% -28.78%
===========================================
Files 1 1
Lines 147 225 +78
===========================================
Hits 122 122
- Misses 25 103 +78 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
marcomangano
left a comment
There was a problem hiding this comment.
Thanks a lot for doing this! Just a few very minor points below
marcomangano
left a comment
There was a problem hiding this comment.
Thanks for the comments, LGTM
| def test_infinite_bounds_not_scaled(self): | ||
| """INFINITY bounds must remain unbounded; scale/offset must not turn | ||
| them into finite numbers in the assembled bounds. | ||
| """ |
There was a problem hiding this comment.
Can you add docstrings like this, that explain what the test is checking, to all these new tests? I usually find LLMs are pretty good at writing them, especially if you tell them to use the Given-When-Then style.
Purpose
Add a few tests, partially addresses #256.
Expected time until merged
A few days
Type of change
Testing
Checklist
ruff checkandruff formatto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable