Ikoka Handheld: Fix LED state polarity#2793
Open
tuxmobil wants to merge 1 commit into
Open
Conversation
LEDs are lit with LED_STATE_ON == 0 as with all Xiao nRF52 boards. This was missing when code used the default PIN_LED + LED_STATE_ON defines, such as the Bluefruit Library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEDs are lit with LED_STATE_ON == 0 as with all Xiao nRF52 boards.
This caused inverted LED behavior when code used the default PIN_LED + LED_STATE_ON defines, such as the Bluefruit Library.