Skip to content

Mark thread_exit_state as voliatile to avoid optimizer ellision #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arr2036 merged 1 commit into from
Jul 3, 2026
Merged

Mark thread_exit_state as voliatile to avoid optimizer ellision #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/linux/platform.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ linux_kqueue_interrupt(struct kqueue *kq);
static void
monitoring_thread_cleanup(void *arg)
{
enum thread_exit_state state = *(enum thread_exit_state *)arg;
enum thread_exit_state state = *(volatile enum thread_exit_state *)arg;
struct kqueue *kq, *kq_tmp;

if ((state == THREAD_EXIT_STATE_CANCEL_LOCKED) ||
Expand Down Expand Up @@ -223,7 +223,7 @@ monitoring_thread_loop(UNUSED void *arg)
int res = 0;
pid_t my_tid;
sigset_t all;
enum thread_exit_state state;
volatile enum thread_exit_state state;

/* Set the thread's name to something descriptive so it shows up in gdb,
* etc. glibc >= 2.1.2 supports pthread_setname_np, but this is a safer way
Expand Down Expand Up @@ -255,7 +255,7 @@ monitoring_thread_loop(UNUSED void *arg)
(void) pthread_mutex_unlock(&monitoring_thread_mtx);

state = THREAD_EXIT_STATE_CANCEL_UNLOCKED;
pthread_cleanup_push(monitoring_thread_cleanup, &state)
pthread_cleanup_push(monitoring_thread_cleanup, (void*)&state)
while (true) {
struct epoll_event events[MONITORING_MAX_EVENTS];
bool drain_req = false;
Expand Down
Loading